Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: ppapi/tests/extensions/BUILD.gn

Issue 1547463004: GN: Properly mark all NaCl test depencies as data_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nacl_helper_nonsfi is not part of Linux installer Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/native_client/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/extensions/BUILD.gn
diff --git a/ppapi/tests/extensions/BUILD.gn b/ppapi/tests/extensions/BUILD.gn
index 741ba71d5069b06d7a1669f0f3b0005d2c3bf2d1..615a103d4ae9f8a16d4c6856430881e546150115 100644
--- a/ppapi/tests/extensions/BUILD.gn
+++ b/ppapi/tests/extensions/BUILD.gn
@@ -8,7 +8,7 @@ import("//ppapi/native_client/nacl_test_data.gni")
group("extensions") {
newlib = "//build/toolchain/nacl:clang_newlib_${target_cpu}"
pnacl = "//build/toolchain/nacl:newlib_pnacl"
- deps = [
+ data_deps = [
":ppapi_tests_extensions_background_keepalive($newlib)",
":ppapi_tests_extensions_load_unload($newlib)",
":ppapi_tests_extensions_media_galleries($newlib)",
@@ -21,7 +21,7 @@ group("extensions") {
]
if ((target_cpu == "x86" || target_cpu == "x64") && is_linux) {
nonsfi = "//build/toolchain/nacl:newlib_pnacl_nonsfi"
- deps += [ ":ppapi_tests_extensions_packaged_app($nonsfi)" ]
+ data_deps += [ ":ppapi_tests_extensions_packaged_app($nonsfi)" ]
}
}
« no previous file with comments | « ppapi/native_client/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698