ppapi/native_client/BUILD.gn - Issue 1547463004: GN: Properly mark all NaCl test depencies as data_deps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/BUILD.gn

Issue 1547463004: GN: Properly mark all NaCl test depencies as data_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nacl_helper_nonsfi is not part of Linux installer Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/native_client/BUILD.gn

diff --git a/ppapi/native_client/BUILD.gn b/ppapi/native_client/BUILD.gn

index 374d970e20940c81757dd2b9d1190c80de6c7f1b..6a358e1ad539942f37105c266f85aaef2f20c874 100644

--- a/ppapi/native_client/BUILD.gn

+++ b/ppapi/native_client/BUILD.gn

@@ -96,14 +96,14 @@ if (is_nacl) {

}

group("irt") {

- public_deps = [

+ data_deps = [

":nacl_irt_debug(//build/toolchain/nacl:irt_${target_cpu})",

":nacl_irt_debuglink(//build/toolchain/nacl:irt_${target_cpu})",

]

# On 32-bit Windows, we also ship the 64-bit IRT.

if (is_win && target_cpu == "x86") {

- public_deps += [

+ data_deps += [

":nacl_irt_debug(//build/toolchain/nacl:irt_x64)",

":nacl_irt_debuglink(//build/toolchain/nacl:irt_x64)",

]

« no previous file with comments | « ppapi/BUILD.gn ('k') | ppapi/tests/extensions/BUILD.gn » ('j') | no next file with comments »