chrome/installer/linux/BUILD.gn - Issue 1547463004: GN: Properly mark all NaCl test depencies as data_deps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/linux/BUILD.gn

Issue 1547463004: GN: Properly mark all NaCl test depencies as data_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/linux/BUILD.gn

diff --git a/chrome/installer/linux/BUILD.gn b/chrome/installer/linux/BUILD.gn

index 866dc39fdfdde8c59a753e4b2f2e177a4d8ea6ab..5159483f9bb4ec8fb3a1ecb1784cfa7088731a0a 100644

--- a/chrome/installer/linux/BUILD.gn

+++ b/chrome/installer/linux/BUILD.gn

@@ -168,6 +168,7 @@ group("installer_deps") {

]

if (enable_nacl) {

public_deps += [

+ "//components/nacl/loader:helper_nonsfi",

brettw 2015/12/22 06:53:37 Are you sure this is right? I didn't think nonsfi

Petr Hosek 2015/12/22 06:55:31 You're right, this one is incorrect.

Petr Hosek 2015/12/22 07:12:59 Done.

"//components/nacl/loader:nacl_helper",

# These are data_deps of nacl_helper, but that is not enough,

« no previous file with comments | « no previous file | chrome/test/BUILD.gn » ('j') | no next file with comments »