Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: chrome/test/BUILD.gn

Issue 1547463004: GN: Properly mark all NaCl test depencies as data_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nacl_helper_nonsfi is not part of Linux installer Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/test/data/nacl/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/config/compiler/compiler.gni") 6 import("//build/config/compiler/compiler.gni")
7 import("//build/config/crypto.gni") 7 import("//build/config/crypto.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/ui.gni") 9 import("//build/config/ui.gni")
10 import("//chrome/chrome_tests.gni") 10 import("//chrome/chrome_tests.gni")
(...skipping 966 matching lines...) Expand 10 before | Expand all | Expand 10 after
977 "//ppapi/tests/extensions", 977 "//ppapi/tests/extensions",
978 ] 978 ]
979 if (is_chromeos) { 979 if (is_chromeos) {
980 sources += [ "//third_party/liblouis/nacl_wrapper/liblouis_wrapper_bro wsertest.cc" ] 980 sources += [ "//third_party/liblouis/nacl_wrapper/liblouis_wrapper_bro wsertest.cc" ]
981 deps += [ "//chrome/browser/chromeos" ] 981 deps += [ "//chrome/browser/chromeos" ]
982 data_deps += [ "//third_party/liblouis:liblouis_test_data" ] 982 data_deps += [ "//third_party/liblouis:liblouis_test_data" ]
983 } 983 }
984 } 984 }
985 if (is_win || is_linux) { 985 if (is_win || is_linux) {
986 sources += [ "../browser/nacl_host/test/nacl_gdb_browsertest.cc" ] 986 sources += [ "../browser/nacl_host/test/nacl_gdb_browsertest.cc" ]
987 deps += [ "//chrome/browser/nacl_host/test:mock_nacl_gdb" ] 987 data_deps += [ "//chrome/browser/nacl_host/test:mock_nacl_gdb" ]
988 } 988 }
989 if (is_win) { 989 if (is_win) {
990 # TODO(halyavin) NaCl on Windows can't open debug stub socket in 990 # TODO(halyavin) NaCl on Windows can't open debug stub socket in
991 # browser process as needed by this test. See http://crbug.com/157312. 991 # browser process as needed by this test. See http://crbug.com/157312.
992 sources -= [ "../browser/nacl_host/test/gdb_debug_stub_browsertest.cc" ] 992 sources -= [ "../browser/nacl_host/test/gdb_debug_stub_browsertest.cc" ]
993 deps += [ 993 deps += [
994 #'chrome.gyp:chrome_nacl_win64', TODO(GYP) bug 512869 994 #'chrome.gyp:chrome_nacl_win64', TODO(GYP) bug 512869
995 ] 995 ]
996 configs -= [ "//build/config/win:default_incremental_linking" ] 996 configs -= [ "//build/config/win:default_incremental_linking" ]
997 configs += 997 configs +=
(...skipping 1240 matching lines...) Expand 10 before | Expand all | Expand 10 after
2238 if (is_android) { 2238 if (is_android) {
2239 android_library("unit_tests_java") { 2239 android_library("unit_tests_java") {
2240 DEPRECATED_java_in_dir = "//chrome/test/android/unit_tests_apk/src" 2240 DEPRECATED_java_in_dir = "//chrome/test/android/unit_tests_apk/src"
2241 deps = [ 2241 deps = [
2242 "//base:base_java", 2242 "//base:base_java",
2243 "//chrome/android:chrome_java", 2243 "//chrome/android:chrome_java",
2244 "//content/public/android:content_java", 2244 "//content/public/android:content_java",
2245 ] 2245 ]
2246 } 2246 }
2247 } 2247 }
OLDNEW
« no previous file with comments | « no previous file | chrome/test/data/nacl/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698