[iOS] Add a HasActiveStateManager method to BrowserState.

[iOS] Add a HasActiveStateManager method to BrowserState.

Add a method to check whether a BrowserState has an ActiveStateManager
to avoid unnecessary object creation during shutdown.

BUG=569515
Committed: https://crrev.com/6eaff4f9763fc6d647b5b31eb5aa6ac18744faee
Cr-Commit-Position: refs/heads/master@{#367076}

[sdefresne, 2015-12-29 14:24:30]

sdefresne@chromium.org changed reviewers:
+ shreyasv@chromium.org

[sdefresne, 2015-12-29 14:24:30]

Please take a look.

[shreyasv1, 2015-12-29 16:09:48]

https://codereview.chromium.org/1547393002/diff/20001/ios/web/browser_state.mm
File ios/web/browser_state.mm (right):

https://codereview.chromium.org/1547393002/diff/20001/ios/web/browser_state.m...
ios/web/browser_state.mm:37: bool
BrowserState::HasActiveStateManager(BrowserState* browser_state) {
OPTIONAL: Move this closer to |GetActiveStateManager|

https://codereview.chromium.org/1547393002/diff/20001/ios/web/browser_state.m...
ios/web/browser_state.mm:39: return
browser_state->GetUserData(kCertificatePolicyCacheKeyName) != nullptr;
Wrong key.

[sdefresne, 2015-12-29 16:14:59]

Please take another look.

https://codereview.chromium.org/1547393002/diff/20001/ios/web/browser_state.mm
File ios/web/browser_state.mm (right):

https://codereview.chromium.org/1547393002/diff/20001/ios/web/browser_state.m...
ios/web/browser_state.mm:37: bool
BrowserState::HasActiveStateManager(BrowserState* browser_state) {
On 2015/12/29 at 16:09:48, shreyasv1 wrote:
> OPTIONAL: Move this closer to |GetActiveStateManager|

Done.

https://codereview.chromium.org/1547393002/diff/20001/ios/web/browser_state.m...
ios/web/browser_state.mm:39: return
browser_state->GetUserData(kCertificatePolicyCacheKeyName) != nullptr;
On 2015/12/29 at 16:09:48, shreyasv1 wrote:
> Wrong key.

Oooops.

[shreyasv1, 2015-12-29 16:44:07]

LGTM.

Consider adding a small test.

https://codereview.chromium.org/1547393002/diff/40001/ios/web/public/browser_...
File ios/web/public/browser_state.h (right):

https://codereview.chromium.org/1547393002/diff/40001/ios/web/public/browser_...
ios/web/public/browser_state.h:37: // Returns whether |browser_state_| has an
associated ActiveStateManager.
NIT: |browser_state|.

[sdefresne, 2015-12-29 16:55:19]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-12-29 16:55:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
shreyasv@chromium.org
Link to the patchset: https://codereview.chromium.org/1547393002/#ps60001
(title: "Fix comment")

[commit-bot: I haz the power, 2015-12-29 16:55:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1547393002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1547393002/60001

[sdefresne, 2015-12-29 16:58:06]

Thank you for the review.

https://codereview.chromium.org/1547393002/diff/40001/ios/web/public/browser_...
File ios/web/public/browser_state.h (right):

https://codereview.chromium.org/1547393002/diff/40001/ios/web/public/browser_...
ios/web/public/browser_state.h:37: // Returns whether |browser_state_| has an
associated ActiveStateManager.
On 2015/12/29 at 16:44:07, shreyasv1 wrote:
> NIT: |browser_state|.

Done.

[commit-bot: I haz the power, 2015-12-29 17:11:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-29 17:12:50]

Description was changed from

==========
[iOS] Add a HasActiveStateManager method to BrowserState.

Add a method to check whether a BrowserState has an ActiveStateManager
to avoid unnecessary object creation during shutdown.

BUG=569515
==========

to

==========
[iOS] Add a HasActiveStateManager method to BrowserState.

Add a method to check whether a BrowserState has an ActiveStateManager
to avoid unnecessary object creation during shutdown.

BUG=569515

Committed: https://crrev.com/6eaff4f9763fc6d647b5b31eb5aa6ac18744faee
Cr-Commit-Position: refs/heads/master@{#367076}
==========

[commit-bot: I haz the power, 2015-12-29 17:12:52]

Patchset 4 (id:??) landed as
https://crrev.com/6eaff4f9763fc6d647b5b31eb5aa6ac18744faee
Cr-Commit-Position: refs/heads/master@{#367076}