Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1547283002: Fix platform_thread_freebsd.cc (Closed)

Created:
4 years, 12 months ago by l2dy
Modified:
4 years, 12 months ago
Reviewers:
Lei Zhang, Nico
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix platform_thread_freebsd.cc Committed: https://crrev.com/5da36b56a662e9a1bac59eaa48c319b08092d9f1 Cr-Commit-Position: refs/heads/master@{#367047}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added me to AUTHORS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/threading/platform_thread_freebsd.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
l2dy
https://codereview.chromium.org/1547283002/diff/1/base/threading/platform_thread_freebsd.cc File base/threading/platform_thread_freebsd.cc (left): https://codereview.chromium.org/1547283002/diff/1/base/threading/platform_thread_freebsd.cc#oldcode19 base/threading/platform_thread_freebsd.cc:19: #include <sys/prctl.h> 404 in FreeBSD https://codereview.chromium.org/1547283002/diff/1/base/threading/platform_thread_freebsd.cc File base/threading/platform_thread_freebsd.cc (right): ...
4 years, 12 months ago (2015-12-28 11:05:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1547283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1547283002/1
4 years, 12 months ago (2015-12-28 11:07:19 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 12 months ago (2015-12-28 11:07:20 UTC) #6
Lei Zhang
lgtm
4 years, 12 months ago (2015-12-28 18:50:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1547283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1547283002/1
4 years, 12 months ago (2015-12-28 18:50:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/131746)
4 years, 12 months ago (2015-12-28 18:58:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1547283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1547283002/20001
4 years, 12 months ago (2015-12-29 03:21:17 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 12 months ago (2015-12-29 03:38:37 UTC) #15
commit-bot: I haz the power
4 years, 12 months ago (2015-12-29 03:39:26 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5da36b56a662e9a1bac59eaa48c319b08092d9f1
Cr-Commit-Position: refs/heads/master@{#367047}

Powered by Google App Engine
This is Rietveld 408576698