net/base/proxy_delegate.h - Issue 1547273003: Set trusted SPDY proxy dynamically on per-profile basis

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/base/proxy_delegate.h

Issue 1547273003: Set trusted SPDY proxy dynamically on per-profile basis (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased, addressed comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef NET_BASE_PROXY_DELEGATE_H_	5 #ifndef NET_BASE_PROXY_DELEGATE_H_

6 #define NET_BASE_PROXY_DELEGATE_H_	6 #define NET_BASE_PROXY_DELEGATE_H_

7	7

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "net/base/net_export.h"	9 #include "net/base/net_export.h"

10	10

(...skipping 49 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
60 virtual void OnTunnelConnectCompleted(const HostPortPair& endpoint,	60 virtual void OnTunnelConnectCompleted(const HostPortPair& endpoint,

61 const HostPortPair& proxy_server,	61 const HostPortPair& proxy_server,

62 int net_error) = 0;	62 int net_error) = 0;

63	63

64 // Called after the response headers for the tunnel request are received.	64 // Called after the response headers for the tunnel request are received.

65 virtual void OnTunnelHeadersReceived(	65 virtual void OnTunnelHeadersReceived(

66 const HostPortPair& origin,	66 const HostPortPair& origin,

67 const HostPortPair& proxy_server,	67 const HostPortPair& proxy_server,

68 const HttpResponseHeaders& response_headers) = 0;	68 const HttpResponseHeaders& response_headers) = 0;

69	69

	70 // Returns true if proxy_server is a trusted SPDY proxy that is allowed to
	mmenke 2016/02/02 16:51:26 \|proxy_server\| \|proxy_server\| tbansal1 2016/02/02 18:18:44 Done. Show quoted text On 2016/02/02 16:51:26, mmenke wrote: > \|proxy_server\| Done.
	71 // push cross-origin resources.
	mmenke 2016/02/02 16:51:26 +"Only affects HTTP2 proxies"? +"Only affects HTTP2 proxies"? tbansal1 2016/02/02 18:18:44 Done. Show quoted text On 2016/02/02 16:51:26, mmenke wrote: > +"Only affects HTTP2 proxies"? Done.
	72 virtual bool IsTrustedSpdyProxy(

	73 const net::ProxyServer& proxy_server) const = 0;
	mmenke 2016/02/02 16:51:26 Suggest removing the const Suggest removing the const tbansal1 2016/02/02 18:18:44 Done. Show quoted text On 2016/02/02 16:51:26, mmenke wrote: > Suggest removing the const Done.
	74

70 private:	75 private:

71 DISALLOW_COPY_AND_ASSIGN(ProxyDelegate);	76 DISALLOW_COPY_AND_ASSIGN(ProxyDelegate);

72 };	77 };

73	78

74 }	79 }

75	80

76 #endif // NET_BASE_PROXY_DELEGATE_H_	81 #endif // NET_BASE_PROXY_DELEGATE_H_

OLD	NEW

« jingle/glue/proxy_resolving_client_socket.cc ('K') | « jingle/glue/proxy_resolving_client_socket.cc ('k') | net/http/http_network_session.h » ('j') | net/spdy/spdy_session.h » ('J')