Set trusted SPDY proxy dynamically on per-profile basis

chrome/browser/io_thread_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/at_exit.h"
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/metrics/field_trial.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/testing_pref_service.h"
 #include "base/run_loop.h"
 #include "base/test/mock_entropy_provider.h"
 #include "build/build_config.h"
 #include "chrome/browser/io_thread.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"
 #include "components/policy/core/common/mock_policy_service.h"
 #include "components/proxy_config/pref_proxy_config_tracker_impl.h"
 #include "components/proxy_config/proxy_config_pref_names.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/test/test_browser_thread_bundle.h"
+#include "net/base/host_port_pair.h"
+#include "net/base/trusted_spdy_proxy_provider.h"
 #include "net/http/http_auth_preferences.h"
 #include "net/http/http_auth_scheme.h"
 #include "net/http/http_network_session.h"
 #include "net/http/http_server_properties_impl.h"
+#include "net/proxy/proxy_server.h"
 #include "net/quic/quic_protocol.h"
 #include "net/quic/quic_stream_factory.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 #if defined(ENABLE_EXTENSIONS)
 #include "chrome/browser/extensions/event_router_forwarder.h"
 #endif
 
 #if defined(OS_CHROMEOS)
@@ skipping 136 matching lines @@
 }
 
 TEST_F(IOThreadTest, SpdyCommandLineUseSpdyOff) {
   command_line_.AppendSwitchASCII("use-spdy", "off");
   // Command line should overwrite field trial group.
   field_trial_group_ = "Spdy4Enabled";
   ConfigureSpdyGlobals();
   EXPECT_EQ(0u, globals_.next_protos.size());
 }
 
+// Tests that the trusted SPDY proxy is set correctly from the command line
+// switch.
+TEST_F(IOThreadTest, TrustedSpdyProxy) {
+  // When command line flag is unspecified, the proxy provider is unavailable.
+  ConfigureSpdyGlobals();
+  EXPECT_FALSE(globals_.trusted_spdy_proxy_provider);
+
+  const net::ProxyServer proxy = net::ProxyServer::FromURI(
+      "example.com:443", net::ProxyServer::SCHEME_HTTP);

[bengr, 2016/01/11 22:29:35]

Once you fix things up so that everything uses ProxyServer instead of
std::string, also verify that no trusted SPDY proxy is set if the proxy server
set on the command line is invalid.

[tbansal1, 2016/01/12 20:50:51]

Done.

+  command_line_.AppendSwitchASCII(switches::kTrustedSpdyProxy,
+                                  proxy.host_port_pair().ToString());
+
+  ConfigureSpdyGlobals();
+  net::ProxyServer got_trusted_spdy_proxy;

[bengr, 2016/01/11 22:29:35]

Call this trusted_spdy_proxy.

[tbansal1, 2016/01/12 20:50:51]

obsolete.

+  globals_.trusted_spdy_proxy_provider->GetTrustedSpdyProxy(
+      &got_trusted_spdy_proxy);
+  EXPECT_EQ(proxy, got_trusted_spdy_proxy);
+}
+
 TEST_F(IOThreadTest, NPNFieldTrialEnabled) {
   field_trial_group_ = "Enable-experiment";
   ConfigureNPNGlobals();
   net::HttpNetworkSession::Params params;
   InitializeNetworkSessionParams(&params);
   EXPECT_TRUE(params.enable_npn);
 }
 
 TEST_F(IOThreadTest, NPNFieldTrialDisabled) {
   field_trial_group_ = "Disable-holdback";
@@ skipping 559 matching lines @@
       &IOThreadTestWithIOThreadObject::CheckAuthAndroidNegoitateAccountType,
       base::Unretained(this), "acc1"));
   pref_service()->SetString(prefs::kAuthAndroidNegotiateAccountType, "acc2");
   RunOnIOThreadBlocking(base::Bind(
       &IOThreadTestWithIOThreadObject::CheckAuthAndroidNegoitateAccountType,
       base::Unretained(this), "acc2"));
 }
 #endif
 
 }  // namespace test