Set trusted SPDY proxy dynamically on per-profile basis

chrome/browser/io_thread.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_IO_THREAD_H_
 #define CHROME_BROWSER_IO_THREAD_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 63 matching lines @@
 class HttpNetworkSession;
 class HttpServerProperties;
 class HttpTransactionFactory;
 class HttpUserAgentSettings;
 class NetworkDelegate;
 class NetworkQualityEstimator;
 class ProxyConfigService;
 class ProxyService;
 class SSLConfigService;
 class TransportSecurityState;
+class TrustedSpdyProxyProvider;
 class URLRequestBackoffManager;
 class URLRequestContext;
 class URLRequestContextGetter;
 class URLRequestJobFactory;
 }  // namespace net
 
 namespace net_log {
 class ChromeNetLog;
 }
 
@@ skipping 107 matching lines @@
     bool ignore_certificate_errors;
     uint16_t testing_fixed_http_port;
     uint16_t testing_fixed_https_port;
     Optional<bool> enable_tcp_fast_open_for_ssl;
 
     Optional<size_t> initial_max_spdy_concurrent_streams;
     Optional<bool> enable_spdy_compression;
     Optional<bool> enable_spdy_ping_based_connection_checking;
     Optional<net::NextProto> spdy_default_protocol;
     net::NextProtoVector next_protos;
-    Optional<std::string> trusted_spdy_proxy;
+    // |trusted_spdy_proxy_provider| provides a trusted SPDY proxy that is

[bengr, 2016/01/11 22:29:35]

There's no need to use || if what's enclosed is obviously code.

provides a trusted SPDY proxy that is allowed to push cross-origin resources ->
provides a proxy server that is allowed to use SPDY to push resources from other
origins.

[tbansal1, 2016/01/12 20:50:50]

Done.

+    // allowed to push cross-origin resources. |trusted_spdy_proxy_provider|
+    // may be NULL.
+    scoped_ptr<net::TrustedSpdyProxyProvider> trusted_spdy_proxy_provider;

[bengr, 2016/01/11 22:29:35]

I wonder if we should instead have a net::TrustedProxyProvider, so that QUIC
could use it too. 

[tbansal1, 2016/01/12 20:50:50]

Changed to TrustedSpdyProxyVerifier.

TrustedProxyProvider would not convey that this is only a HTTP2/SPDY  proxy
verifier.

     std::set<net::HostPortPair> forced_spdy_exclusions;
     Optional<bool> use_alternative_services;
     Optional<double> alternative_service_probability_threshold;
 
     Optional<bool> enable_npn;
 
     Optional<bool> enable_brotli;
 
     Optional<bool> enable_quic;
     Optional<bool> enable_quic_for_proxies;
@@ skipping 348 matching lines @@
   bool is_quic_allowed_by_policy_;
 
   const base::TimeTicks creation_time_;
 
   base::WeakPtrFactory<IOThread> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(IOThread);
 };
 
 #endif  // CHROME_BROWSER_IO_THREAD_H_