third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp - Issue 1547263002: Fix SVGInlineTextMetricsIterator not to keep a pointer to LineLayoutItem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

Issue 1547263002: Fix SVGInlineTextMetricsIterator not to keep a pointer to LineLayoutItem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: eae review, remove excessive assert Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

index 49254562c2c67009f021befedf854379a8179d49..295870351e7c3469f8d399fe40d6a14f09921911 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

@@ -357,7 +357,7 @@ void SVGTextLayoutEngine::layoutTextOnLineOrPath(SVGInlineTextBox* textBox, Line

return;

// Find the start of the current text box in the metrics list.

- m_visualMetricsIterator.advanceToTextStart(&textLineLayout, textBox->start());

+ m_visualMetricsIterator.advanceToTextStart(textLineLayout, textBox->start());

const Font& font = style.font();

« no previous file with comments | « third_party/WebKit/Source/core/layout/api/LineLayoutSVGInlineText.h ('k') | no next file » | no next file with comments »