Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1547223002: Convert Pass()→std::move() in //ash (Closed)

Created:
4 years, 12 months ago by dcheng
Modified:
4 years, 12 months ago
CC:
dcheng, chromium-reviews, darin-cc_chromium.org, jam, kalyank, sadrul, tdanderson+overview_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //ash ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=avi@chromium.org TBR=oshima@chromium.org Committed: https://crrev.com/cbf0d9d06946a963687f009f53f66c599d07b03c Cr-Commit-Position: refs/heads/master@{#366940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -126 lines) Patch
M ash/accelerators/accelerator_controller.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/display/mirror_window_controller.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M ash/display/mouse_cursor_event_filter.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M ash/display/window_tree_host_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/frame/custom_frame_view_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/host/ash_window_tree_host_unified.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ash/host/ash_window_tree_host_x11.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/host/transformer_helper.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/magnifier/magnification_controller.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ash/metrics/desktop_task_switch_metric_recorder_unittest.cc View 10 chunks +15 lines, -25 lines 0 comments Download
M ash/rotator/screen_rotation_animator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_button_pressed_metric_tracker_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/shelf/shelf_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 6 chunks +6 lines, -11 lines 0 comments Download
M ash/shelf/shelf_window_watcher.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/shell.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/shell/app_list.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/shell/content/client/shell_content_browser_client.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/shell/window_type_launcher.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M ash/shell/window_watcher.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/system/audio/tray_audio.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/locale/locale_notification_controller.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ash/system/tray/default_system_tray_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/user/user_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/test/test_shelf_delegate.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/touch/touch_hud_debug.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/lock_state_controller.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ash/wm/lock_window_state.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_x11.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/overview/window_grid.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/overview/window_selector.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/wm/window_animations.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/window_state.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M ash/wm/window_state_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M ash/wm/workspace/phantom_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/wm/workspace_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
dcheng
+avi for general review / sanity check +oshima for OWNERS review
4 years, 12 months ago (2015-12-27 20:43:04 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1547223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1547223002/1
4 years, 12 months ago (2015-12-27 20:43:24 UTC) #5
Avi (use Gerrit)
lgtm stampity stamp
4 years, 12 months ago (2015-12-27 21:21:36 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-27 22:37:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1547223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1547223002/1
4 years, 12 months ago (2015-12-27 22:44:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-27 22:49:31 UTC) #11
commit-bot: I haz the power
4 years, 12 months ago (2015-12-27 22:50:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbf0d9d06946a963687f009f53f66c599d07b03c
Cr-Commit-Position: refs/heads/master@{#366940}

Powered by Google App Engine
This is Rietveld 408576698