Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1547183002: Catch null return value from computeComputedStyle. (Closed)

Created:
4 years, 11 months ago by shans
Modified:
4 years, 11 months ago
Reviewers:
dstockwell, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Catch null return value from computeComputedStyle. This patch is in response to a Crash Report, so I don't have a repro. I haven't been able to trigger the condition locally. However it seems that other call sites to ensureComputedStyle (which computeComputedStyle calls through to) perform a null check, so it's sensible that we need to here as well. Unfortunately, no repro means no test case :( BUG=571040 Committed: https://crrev.com/58099385dfca252653e833ba1a6e3e83b196e402 Cr-Commit-Position: refs/heads/master@{#367288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
shans
4 years, 11 months ago (2015-12-27 03:10:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1547183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1547183002/1
4 years, 11 months ago (2015-12-27 03:11:05 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-27 04:45:19 UTC) #6
dstockwell
lgtm
4 years, 11 months ago (2016-01-03 21:42:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1547183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1547183002/1
4 years, 11 months ago (2016-01-03 22:02:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-03 23:19:20 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/58099385dfca252653e833ba1a6e3e83b196e402 Cr-Commit-Position: refs/heads/master@{#367288}
4 years, 11 months ago (2016-01-03 23:20:14 UTC) #12
rune
4 years, 11 months ago (2016-01-04 10:29:23 UTC) #14
Message was sent while issue was closed.
I've made a test here:

https://codereview.chromium.org/1553083002/

Powered by Google App Engine
This is Rietveld 408576698