Issue 25313. Skip constructor names and named expressions.

pkg/analysis_server/lib/src/services/refactoring/extract_local.dart

Index: pkg/analysis_server/lib/src/services/refactoring/extract_local.dart
diff --git a/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart b/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart
index ca90fd2616e48535ddfecbfbd667af387c618e33..c027600fc12b01bb0899463c5516187050a8ea34 100644
--- a/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart
+++ b/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart
@@ -230,10 +230,30 @@ class ExtractLocalRefactoringImpl extends RefactoringImpl
         new NodeLocator(selectionRange.offset, selectionRange.end)
             .searchWithin(unit);
     // compute covering expressions
-    for (AstNode node = coveringNode;
-        node is Expression || node is ArgumentList;
-        node = node.parent) {
+    for (AstNode node = coveringNode;; node = node.parent) {

[Brian Wilkerson, 2015/12/27 16:49:42]

Perhaps replace the condition with "node != null"? It feels safer, but perhaps
it's not necessary.

       AstNode parent = node.parent;
+      // skip some nodes
+      if (node is ArgumentList ||
+          node is AssignmentExpression ||
+          node is NamedExpression ||
+          node is TypeArgumentList) {
+        continue;
+      }
+      if (node is ConstructorName || node is Label || node is TypeName) {
+        rootExpression = null;
+        coveringExpressionOffsets.clear();
+        coveringExpressionLengths.clear();
+        continue;
+      }
+      // cannot extract the name part of a property access
+      if (parent is PrefixedIdentifier && parent.identifier == node ||
+          parent is PropertyAccess && parent.propertyName == node) {
+        continue;
+      }
+      // stop if not an Expression
+      if (node is! Expression) {
+        break;
+      }
       // stop at void method invocations
       if (node is MethodInvocation) {
         MethodInvocation invocation = node;
@@ -249,19 +269,6 @@ class ExtractLocalRefactoringImpl extends RefactoringImpl
           break;
         }
       }
-      // skip ArgumentList
-      if (node is ArgumentList) {
-        continue;
-      }
-      // skip AssignmentExpression
-      if (node is AssignmentExpression) {
-        continue;
-      }
-      // cannot extract the name part of a property access
-      if (parent is PrefixedIdentifier && parent.identifier == node ||
-          parent is PropertyAccess && parent.propertyName == node) {
-        continue;
-      }
       // fatal selection problems
       if (coveringExpressionOffsets.isEmpty) {
         if (node is SimpleIdentifier) {