Issue 25313. Skip constructor names and named expressions.

pkg/analysis_server/test/services/refactoring/extract_local_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.refactoring.extract_local;
 
 import 'dart:async';
 import 'dart:convert';
 
 import 'package:analysis_server/plugin/protocol/protocol.dart';
@@ skipping 408 matching lines @@
 }
 void foo(int x) {}
 ''');
     _createRefactoring(testCode.indexOf('11 +'), 0);
     // check conditions
     await refactoring.checkInitialConditions();
     List<String> subExpressions = _getCoveringExpressions();
     expect(subExpressions, ['111', '111 + 222']);
   }
 
-  test_coveringExpressions_skipAssignments() async {
+  test_coveringExpressions_namedExpression_value() async {
+    indexTestUnit('''
+main() {
+  foo(ppp: 42);
+}
+int foo({int ppp: 0}) => ppp + 1;
+''');
+    _createRefactoring(testCode.indexOf('42'), 0);
+    // check conditions
+    await refactoring.checkInitialConditions();
+    List<String> subExpressions = _getCoveringExpressions();
+    expect(subExpressions, ['42', 'foo(ppp: 42)']);
+  }
+
+  test_coveringExpressions_skip_assignment() async {
     indexTestUnit('''
 main() {
   int v;
   foo(v = 111 + 222);
 }
 int foo(x) => 42;
 ''');
     _createRefactoring(testCode.indexOf('11 +'), 0);
     // check conditions
     await refactoring.checkInitialConditions();
     List<String> subExpressions = _getCoveringExpressions();
     expect(subExpressions, ['111', '111 + 222', 'foo(v = 111 + 222)']);
   }
 
+  test_coveringExpressions_skip_constructorName() async {
+    indexTestUnit('''
+class AAA {
+  AAA.name() {}
+}
+main() {
+  int v = new AAA.name();
+}
+''');
+    _createRefactoring(testCode.indexOf('AA.name();'), 5);
+    // check conditions
+    await refactoring.checkInitialConditions();
+    List<String> subExpressions = _getCoveringExpressions();
+    expect(subExpressions, ['new AAA.name()']);
+  }
+
+  test_coveringExpressions_skip_constructorName_name() async {
+    indexTestUnit('''
+class A {
+  A.name() {}
+}
+main() {
+  int v = new A.name();
+}
+''');
+    _createRefactoring(testCode.indexOf('ame();'), 0);
+    // check conditions
+    await refactoring.checkInitialConditions();
+    List<String> subExpressions = _getCoveringExpressions();
+    expect(subExpressions, ['new A.name()']);
+  }
+
+  test_coveringExpressions_skip_constructorName_type() async {
+    indexTestUnit('''
+class A {}
+main() {
+  int v = new A();
+}
+''');
+    _createRefactoring(testCode.indexOf('A();'), 0);
+    // check conditions
+    await refactoring.checkInitialConditions();
+    List<String> subExpressions = _getCoveringExpressions();
+    expect(subExpressions, ['new A()']);
+  }
+
+  test_coveringExpressions_skip_constructorName_typeArgument() async {
+    indexTestUnit('''
+class A<T> {}
+main() {
+  int v = new A<String>();
+}
+''');
+    _createRefactoring(testCode.indexOf('ring>'), 0);
+    // check conditions
+    await refactoring.checkInitialConditions();
+    List<String> subExpressions = _getCoveringExpressions();
+    expect(subExpressions, ['new A<String>()']);
+  }
+
+  test_coveringExpressions_skip_namedExpression() async {
+    indexTestUnit('''
+main() {
+  foo(ppp: 42);
+}
+int foo({int ppp: 0}) => ppp + 1;
+''');
+    _createRefactoring(testCode.indexOf('pp: 42'), 0);
+    // check conditions
+    await refactoring.checkInitialConditions();
+    List<String> subExpressions = _getCoveringExpressions();
+    expect(subExpressions, ['foo(ppp: 42)']);
+  }
+
   test_fragmentExpression() {
     indexTestUnit('''
 main() {
   int a = 1 + 2 + 3 + 4;
 }
 ''');
     _createRefactoringForString('2 + 3');
     // apply refactoring
     return _assertSuccessfulRefactoring('''
 main() {
@@ skipping 757 matching lines @@
   List<String> _getCoveringExpressions() {
     List<String> subExpressions = <String>[];
     for (int i = 0; i < refactoring.coveringExpressionOffsets.length; i++) {
       int offset = refactoring.coveringExpressionOffsets[i];
       int length = refactoring.coveringExpressionLengths[i];
       subExpressions.add(testCode.substring(offset, offset + length));
     }
     return subExpressions;
   }
 }