Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1547113002: Issue 25313. Skip constructor names and named expressions. (Closed)

Created:
4 years, 12 months ago by scheglov
Modified:
4 years, 12 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : node != null #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -17 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/extract_local.dart View 1 2 chunks +23 lines, -16 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 2 chunks +89 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 12 months ago (2015-12-25 01:56:18 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1547113002/diff/1/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart File pkg/analysis_server/lib/src/services/refactoring/extract_local.dart (right): https://codereview.chromium.org/1547113002/diff/1/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart#newcode233 pkg/analysis_server/lib/src/services/refactoring/extract_local.dart:233: for (AstNode node = coveringNode;; node = node.parent) ...
4 years, 12 months ago (2015-12-27 16:49:42 UTC) #2
scheglov
4 years, 12 months ago (2015-12-27 20:05:11 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
78ae012d2da31c0d10e918402081e1562fbe5967 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698