chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc - Issue 1547093002: Switch to standard integer types in chrome/browser/chromeos/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc

Issue 1547093002: Switch to standard integer types in chrome/browser/chromeos/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc ('k') | chrome/browser/chromeos/policy/device_status_collector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc

diff --git a/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc b/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc

index 03ea6c023da9449a0ad1048b433493e4b2df7e3c..58185df59fd54dbdfe99a2a981a01e1a99ae9b26 100644

--- a/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc

+++ b/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc

@@ -4,12 +4,15 @@

#include "chrome/browser/chromeos/policy/device_policy_decoder_chromeos.h"

+#include <stdint.h>

#include <limits>

#include <string>

#include "base/callback.h"

#include "base/json/json_reader.h"

#include "base/logging.h"

+#include "base/macros.h"

#include "base/values.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/chromeos/policy/device_local_account.h"

@@ -36,7 +39,7 @@ namespace {

// Decodes a protobuf integer to an IntegerValue. Returns NULL in case the input

// value is out of bounds.

-scoped_ptr<base::Value> DecodeIntegerValue(google::protobuf::int64 value) {

+scoped_ptr<base::Value> DecodeIntegerValue(google::protobuf::int64_t value) {

if (value < std::numeric_limits<int>::min() ||

value > std::numeric_limits<int>::max()) {

LOG(WARNING) << "Integer value " << value