chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc - Issue 1547093002: Switch to standard integer types in chrome/browser/chromeos/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc

Issue 1547093002: Switch to standard integer types in chrome/browser/chromeos/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/cloud_external_data_manager_base.h ('k') | chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc

diff --git a/chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc b/chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc

index ebde8d3719087bf6407a17f1e8c11b4f50650735..82cc488871d1d7c1a6bab8353b4ef28775a9d948 100644

--- a/chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc

+++ b/chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc

@@ -4,6 +4,9 @@

#include "chrome/browser/chromeos/policy/cloud_external_data_manager_base.h"

+#include <stddef.h>

+#include <stdint.h>

#include <map>

#include <string>

#include <vector>

@@ -13,6 +16,7 @@

#include "base/callback.h"

#include "base/location.h"

#include "base/logging.h"

+#include "base/macros.h"

#include "base/sequenced_task_runner.h"

#include "base/single_thread_task_runner.h"

#include "base/strings/string_number_conversions.h"

@@ -386,7 +390,7 @@ void CloudExternalDataManagerBase::OnPolicyStoreLoaded() {

const base::DictionaryValue* dict = NULL;

std::string url;

std::string hex_hash;

- std::vector<uint8> hash;

+ std::vector<uint8_t> hash;

if (it->second.value && it->second.value->GetAsDictionary(&dict) &&

dict->GetStringWithoutPathExpansion("url", &url) &&

dict->GetStringWithoutPathExpansion("hash", &hex_hash) &&