Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Side by Side Diff: chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader_unittest.cc

Issue 1547093002: Switch to standard integer types in chrome/browser/chromeos/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reade r.h" 5 #include "chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reade r.h"
6 6
7 #include <stddef.h>
8 #include <stdint.h>
9
7 #include <string> 10 #include <string>
8 #include <vector> 11 #include <vector>
9 12
10 #include "base/files/file.h" 13 #include "base/files/file.h"
11 #include "base/files/file_path.h" 14 #include "base/files/file_path.h"
12 #include "base/files/scoped_temp_dir.h" 15 #include "base/files/scoped_temp_dir.h"
16 #include "base/macros.h"
13 #include "base/memory/scoped_ptr.h" 17 #include "base/memory/scoped_ptr.h"
14 #include "base/memory/weak_ptr.h" 18 #include "base/memory/weak_ptr.h"
15 #include "base/numerics/safe_math.h" 19 #include "base/numerics/safe_math.h"
16 #include "base/run_loop.h" 20 #include "base/run_loop.h"
17 #include "chrome/browser/chromeos/file_system_provider/fake_provided_file_system .h" 21 #include "chrome/browser/chromeos/file_system_provider/fake_provided_file_system .h"
18 #include "chrome/browser/chromeos/file_system_provider/service.h" 22 #include "chrome/browser/chromeos/file_system_provider/service.h"
19 #include "chrome/browser/chromeos/file_system_provider/service_factory.h" 23 #include "chrome/browser/chromeos/file_system_provider/service_factory.h"
20 #include "chrome/test/base/testing_browser_process.h" 24 #include "chrome/test/base/testing_browser_process.h"
21 #include "chrome/test/base/testing_profile.h" 25 #include "chrome/test/base/testing_profile.h"
22 #include "chrome/test/base/testing_profile_manager.h" 26 #include "chrome/test/base/testing_profile_manager.h"
(...skipping 14 matching lines...) Expand all
37 const char kExtensionId[] = "mbflcebpggnecokmikipoihdbecnjfoj"; 41 const char kExtensionId[] = "mbflcebpggnecokmikipoihdbecnjfoj";
38 const char kFileSystemId[] = "testing-file-system"; 42 const char kFileSystemId[] = "testing-file-system";
39 43
40 // Logs callbacks invocations on the file stream reader. 44 // Logs callbacks invocations on the file stream reader.
41 class EventLogger { 45 class EventLogger {
42 public: 46 public:
43 EventLogger() : weak_ptr_factory_(this) {} 47 EventLogger() : weak_ptr_factory_(this) {}
44 virtual ~EventLogger() {} 48 virtual ~EventLogger() {}
45 49
46 void OnRead(int result) { results_.push_back(result); } 50 void OnRead(int result) { results_.push_back(result); }
47 void OnGetLength(int64 result) { results_.push_back(result); } 51 void OnGetLength(int64_t result) { results_.push_back(result); }
48 52
49 base::WeakPtr<EventLogger> GetWeakPtr() { 53 base::WeakPtr<EventLogger> GetWeakPtr() {
50 return weak_ptr_factory_.GetWeakPtr(); 54 return weak_ptr_factory_.GetWeakPtr();
51 } 55 }
52 56
53 const std::vector<int64>& results() const { return results_; } 57 const std::vector<int64_t>& results() const { return results_; }
54 58
55 private: 59 private:
56 std::vector<int64> results_; 60 std::vector<int64_t> results_;
57 base::WeakPtrFactory<EventLogger> weak_ptr_factory_; 61 base::WeakPtrFactory<EventLogger> weak_ptr_factory_;
58 62
59 DISALLOW_COPY_AND_ASSIGN(EventLogger); 63 DISALLOW_COPY_AND_ASSIGN(EventLogger);
60 }; 64 };
61 65
62 // Creates a cracked FileSystemURL for tests. 66 // Creates a cracked FileSystemURL for tests.
63 storage::FileSystemURL CreateFileSystemURL(const std::string& mount_point_name, 67 storage::FileSystemURL CreateFileSystemURL(const std::string& mount_point_name,
64 const base::FilePath& file_path) { 68 const base::FilePath& file_path) {
65 const std::string origin = std::string("chrome-extension://") + kExtensionId; 69 const std::string origin = std::string("chrome-extension://") + kExtensionId;
66 const storage::ExternalMountPoints* const mount_points = 70 const storage::ExternalMountPoints* const mount_points =
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 scoped_ptr<TestingProfileManager> profile_manager_; 121 scoped_ptr<TestingProfileManager> profile_manager_;
118 TestingProfile* profile_; // Owned by TestingProfileManager. 122 TestingProfile* profile_; // Owned by TestingProfileManager.
119 const FakeEntry* fake_file_; // Owned by FakePRovidedFileSystem. 123 const FakeEntry* fake_file_; // Owned by FakePRovidedFileSystem.
120 storage::FileSystemURL file_url_; 124 storage::FileSystemURL file_url_;
121 storage::FileSystemURL wrong_file_url_; 125 storage::FileSystemURL wrong_file_url_;
122 }; 126 };
123 127
124 TEST_F(FileSystemProviderFileStreamReader, Read_AllAtOnce) { 128 TEST_F(FileSystemProviderFileStreamReader, Read_AllAtOnce) {
125 EventLogger logger; 129 EventLogger logger;
126 130
127 const int64 initial_offset = 0; 131 const int64_t initial_offset = 0;
128 FileStreamReader reader(NULL, file_url_, initial_offset, 132 FileStreamReader reader(NULL, file_url_, initial_offset,
129 *fake_file_->metadata->modification_time); 133 *fake_file_->metadata->modification_time);
130 scoped_refptr<net::IOBuffer> io_buffer(new net::IOBuffer( 134 scoped_refptr<net::IOBuffer> io_buffer(new net::IOBuffer(
131 base::CheckedNumeric<size_t>(*fake_file_->metadata->size).ValueOrDie())); 135 base::CheckedNumeric<size_t>(*fake_file_->metadata->size).ValueOrDie()));
132 136
133 const int result = 137 const int result =
134 reader.Read(io_buffer.get(), *fake_file_->metadata->size, 138 reader.Read(io_buffer.get(), *fake_file_->metadata->size,
135 base::Bind(&EventLogger::OnRead, logger.GetWeakPtr())); 139 base::Bind(&EventLogger::OnRead, logger.GetWeakPtr()));
136 EXPECT_EQ(net::ERR_IO_PENDING, result); 140 EXPECT_EQ(net::ERR_IO_PENDING, result);
137 base::RunLoop().RunUntilIdle(); 141 base::RunLoop().RunUntilIdle();
138 142
139 ASSERT_EQ(1u, logger.results().size()); 143 ASSERT_EQ(1u, logger.results().size());
140 EXPECT_LT(0, logger.results()[0]); 144 EXPECT_LT(0, logger.results()[0]);
141 EXPECT_EQ(*fake_file_->metadata->size, logger.results()[0]); 145 EXPECT_EQ(*fake_file_->metadata->size, logger.results()[0]);
142 146
143 std::string buffer_as_string(io_buffer->data(), *fake_file_->metadata->size); 147 std::string buffer_as_string(io_buffer->data(), *fake_file_->metadata->size);
144 EXPECT_EQ(fake_file_->contents, buffer_as_string); 148 EXPECT_EQ(fake_file_->contents, buffer_as_string);
145 } 149 }
146 150
147 TEST_F(FileSystemProviderFileStreamReader, Read_WrongFile) { 151 TEST_F(FileSystemProviderFileStreamReader, Read_WrongFile) {
148 EventLogger logger; 152 EventLogger logger;
149 153
150 const int64 initial_offset = 0; 154 const int64_t initial_offset = 0;
151 FileStreamReader reader(NULL, wrong_file_url_, initial_offset, 155 FileStreamReader reader(NULL, wrong_file_url_, initial_offset,
152 *fake_file_->metadata->modification_time); 156 *fake_file_->metadata->modification_time);
153 scoped_refptr<net::IOBuffer> io_buffer(new net::IOBuffer( 157 scoped_refptr<net::IOBuffer> io_buffer(new net::IOBuffer(
154 base::CheckedNumeric<size_t>(*fake_file_->metadata->size).ValueOrDie())); 158 base::CheckedNumeric<size_t>(*fake_file_->metadata->size).ValueOrDie()));
155 159
156 const int result = 160 const int result =
157 reader.Read(io_buffer.get(), *fake_file_->metadata->size, 161 reader.Read(io_buffer.get(), *fake_file_->metadata->size,
158 base::Bind(&EventLogger::OnRead, logger.GetWeakPtr())); 162 base::Bind(&EventLogger::OnRead, logger.GetWeakPtr()));
159 EXPECT_EQ(net::ERR_IO_PENDING, result); 163 EXPECT_EQ(net::ERR_IO_PENDING, result);
160 base::RunLoop().RunUntilIdle(); 164 base::RunLoop().RunUntilIdle();
161 165
162 ASSERT_EQ(1u, logger.results().size()); 166 ASSERT_EQ(1u, logger.results().size());
163 EXPECT_EQ(net::ERR_FILE_NOT_FOUND, logger.results()[0]); 167 EXPECT_EQ(net::ERR_FILE_NOT_FOUND, logger.results()[0]);
164 } 168 }
165 169
166 TEST_F(FileSystemProviderFileStreamReader, Read_InChunks) { 170 TEST_F(FileSystemProviderFileStreamReader, Read_InChunks) {
167 EventLogger logger; 171 EventLogger logger;
168 172
169 const int64 initial_offset = 0; 173 const int64_t initial_offset = 0;
170 FileStreamReader reader(NULL, file_url_, initial_offset, 174 FileStreamReader reader(NULL, file_url_, initial_offset,
171 *fake_file_->metadata->modification_time); 175 *fake_file_->metadata->modification_time);
172 176
173 for (int64 offset = 0; offset < *fake_file_->metadata->size; ++offset) { 177 for (int64_t offset = 0; offset < *fake_file_->metadata->size; ++offset) {
174 scoped_refptr<net::IOBuffer> io_buffer(new net::IOBuffer(1)); 178 scoped_refptr<net::IOBuffer> io_buffer(new net::IOBuffer(1));
175 const int result = 179 const int result =
176 reader.Read(io_buffer.get(), 180 reader.Read(io_buffer.get(),
177 1, 181 1,
178 base::Bind(&EventLogger::OnRead, logger.GetWeakPtr())); 182 base::Bind(&EventLogger::OnRead, logger.GetWeakPtr()));
179 EXPECT_EQ(net::ERR_IO_PENDING, result); 183 EXPECT_EQ(net::ERR_IO_PENDING, result);
180 base::RunLoop().RunUntilIdle(); 184 base::RunLoop().RunUntilIdle();
181 ASSERT_EQ(offset + 1, static_cast<int64>(logger.results().size())); 185 ASSERT_EQ(offset + 1, static_cast<int64_t>(logger.results().size()));
182 EXPECT_EQ(1, logger.results()[offset]); 186 EXPECT_EQ(1, logger.results()[offset]);
183 EXPECT_EQ(fake_file_->contents[offset], io_buffer->data()[0]); 187 EXPECT_EQ(fake_file_->contents[offset], io_buffer->data()[0]);
184 } 188 }
185 } 189 }
186 190
187 TEST_F(FileSystemProviderFileStreamReader, Read_Slice) { 191 TEST_F(FileSystemProviderFileStreamReader, Read_Slice) {
188 EventLogger logger; 192 EventLogger logger;
189 193
190 // Trim first 3 and last 3 characters. 194 // Trim first 3 and last 3 characters.
191 const int64 initial_offset = 3; 195 const int64_t initial_offset = 3;
192 const int length = *fake_file_->metadata->size - initial_offset - 3; 196 const int length = *fake_file_->metadata->size - initial_offset - 3;
193 ASSERT_GT(*fake_file_->metadata->size, initial_offset); 197 ASSERT_GT(*fake_file_->metadata->size, initial_offset);
194 ASSERT_LT(0, length); 198 ASSERT_LT(0, length);
195 199
196 FileStreamReader reader(NULL, file_url_, initial_offset, 200 FileStreamReader reader(NULL, file_url_, initial_offset,
197 *fake_file_->metadata->modification_time); 201 *fake_file_->metadata->modification_time);
198 scoped_refptr<net::IOBuffer> io_buffer(new net::IOBuffer(length)); 202 scoped_refptr<net::IOBuffer> io_buffer(new net::IOBuffer(length));
199 203
200 const int result = 204 const int result =
201 reader.Read(io_buffer.get(), 205 reader.Read(io_buffer.get(),
202 length, 206 length,
203 base::Bind(&EventLogger::OnRead, logger.GetWeakPtr())); 207 base::Bind(&EventLogger::OnRead, logger.GetWeakPtr()));
204 EXPECT_EQ(net::ERR_IO_PENDING, result); 208 EXPECT_EQ(net::ERR_IO_PENDING, result);
205 base::RunLoop().RunUntilIdle(); 209 base::RunLoop().RunUntilIdle();
206 210
207 ASSERT_EQ(1u, logger.results().size()); 211 ASSERT_EQ(1u, logger.results().size());
208 EXPECT_EQ(length, logger.results()[0]); 212 EXPECT_EQ(length, logger.results()[0]);
209 213
210 std::string buffer_as_string(io_buffer->data(), length); 214 std::string buffer_as_string(io_buffer->data(), length);
211 std::string expected_buffer(fake_file_->contents.data() + initial_offset, 215 std::string expected_buffer(fake_file_->contents.data() + initial_offset,
212 length); 216 length);
213 EXPECT_EQ(expected_buffer, buffer_as_string); 217 EXPECT_EQ(expected_buffer, buffer_as_string);
214 } 218 }
215 219
216 TEST_F(FileSystemProviderFileStreamReader, Read_Beyond) { 220 TEST_F(FileSystemProviderFileStreamReader, Read_Beyond) {
217 EventLogger logger; 221 EventLogger logger;
218 222
219 // Request reading 1KB more than available. 223 // Request reading 1KB more than available.
220 const int64 initial_offset = 0; 224 const int64_t initial_offset = 0;
221 const int length = *fake_file_->metadata->size + 1024; 225 const int length = *fake_file_->metadata->size + 1024;
222 226
223 FileStreamReader reader(NULL, file_url_, initial_offset, 227 FileStreamReader reader(NULL, file_url_, initial_offset,
224 *fake_file_->metadata->modification_time); 228 *fake_file_->metadata->modification_time);
225 scoped_refptr<net::IOBuffer> io_buffer(new net::IOBuffer(length)); 229 scoped_refptr<net::IOBuffer> io_buffer(new net::IOBuffer(length));
226 230
227 const int result = 231 const int result =
228 reader.Read(io_buffer.get(), 232 reader.Read(io_buffer.get(),
229 length, 233 length,
230 base::Bind(&EventLogger::OnRead, logger.GetWeakPtr())); 234 base::Bind(&EventLogger::OnRead, logger.GetWeakPtr()));
231 EXPECT_EQ(net::ERR_IO_PENDING, result); 235 EXPECT_EQ(net::ERR_IO_PENDING, result);
232 base::RunLoop().RunUntilIdle(); 236 base::RunLoop().RunUntilIdle();
233 237
234 ASSERT_EQ(1u, logger.results().size()); 238 ASSERT_EQ(1u, logger.results().size());
235 EXPECT_LT(0, logger.results()[0]); 239 EXPECT_LT(0, logger.results()[0]);
236 EXPECT_EQ(*fake_file_->metadata->size, logger.results()[0]); 240 EXPECT_EQ(*fake_file_->metadata->size, logger.results()[0]);
237 241
238 std::string buffer_as_string(io_buffer->data(), *fake_file_->metadata->size); 242 std::string buffer_as_string(io_buffer->data(), *fake_file_->metadata->size);
239 EXPECT_EQ(fake_file_->contents, buffer_as_string); 243 EXPECT_EQ(fake_file_->contents, buffer_as_string);
240 } 244 }
241 245
242 TEST_F(FileSystemProviderFileStreamReader, Read_ModifiedFile) { 246 TEST_F(FileSystemProviderFileStreamReader, Read_ModifiedFile) {
243 EventLogger logger; 247 EventLogger logger;
244 248
245 const int64 initial_offset = 0; 249 const int64_t initial_offset = 0;
246 FileStreamReader reader(NULL, file_url_, initial_offset, base::Time::Max()); 250 FileStreamReader reader(NULL, file_url_, initial_offset, base::Time::Max());
247 251
248 scoped_refptr<net::IOBuffer> io_buffer(new net::IOBuffer( 252 scoped_refptr<net::IOBuffer> io_buffer(new net::IOBuffer(
249 base::CheckedNumeric<size_t>(*fake_file_->metadata->size).ValueOrDie())); 253 base::CheckedNumeric<size_t>(*fake_file_->metadata->size).ValueOrDie()));
250 const int result = 254 const int result =
251 reader.Read(io_buffer.get(), *fake_file_->metadata->size, 255 reader.Read(io_buffer.get(), *fake_file_->metadata->size,
252 base::Bind(&EventLogger::OnRead, logger.GetWeakPtr())); 256 base::Bind(&EventLogger::OnRead, logger.GetWeakPtr()));
253 257
254 EXPECT_EQ(net::ERR_IO_PENDING, result); 258 EXPECT_EQ(net::ERR_IO_PENDING, result);
255 base::RunLoop().RunUntilIdle(); 259 base::RunLoop().RunUntilIdle();
256 260
257 ASSERT_EQ(1u, logger.results().size()); 261 ASSERT_EQ(1u, logger.results().size());
258 EXPECT_EQ(net::ERR_UPLOAD_FILE_CHANGED, logger.results()[0]); 262 EXPECT_EQ(net::ERR_UPLOAD_FILE_CHANGED, logger.results()[0]);
259 } 263 }
260 264
261 TEST_F(FileSystemProviderFileStreamReader, Read_ExpectedModificationTimeNull) { 265 TEST_F(FileSystemProviderFileStreamReader, Read_ExpectedModificationTimeNull) {
262 EventLogger logger; 266 EventLogger logger;
263 267
264 const int64 initial_offset = 0; 268 const int64_t initial_offset = 0;
265 FileStreamReader reader(NULL, file_url_, initial_offset, base::Time()); 269 FileStreamReader reader(NULL, file_url_, initial_offset, base::Time());
266 270
267 scoped_refptr<net::IOBuffer> io_buffer(new net::IOBuffer( 271 scoped_refptr<net::IOBuffer> io_buffer(new net::IOBuffer(
268 base::CheckedNumeric<size_t>(*fake_file_->metadata->size).ValueOrDie())); 272 base::CheckedNumeric<size_t>(*fake_file_->metadata->size).ValueOrDie()));
269 const int result = 273 const int result =
270 reader.Read(io_buffer.get(), *fake_file_->metadata->size, 274 reader.Read(io_buffer.get(), *fake_file_->metadata->size,
271 base::Bind(&EventLogger::OnRead, logger.GetWeakPtr())); 275 base::Bind(&EventLogger::OnRead, logger.GetWeakPtr()));
272 276
273 EXPECT_EQ(net::ERR_IO_PENDING, result); 277 EXPECT_EQ(net::ERR_IO_PENDING, result);
274 base::RunLoop().RunUntilIdle(); 278 base::RunLoop().RunUntilIdle();
275 279
276 ASSERT_EQ(1u, logger.results().size()); 280 ASSERT_EQ(1u, logger.results().size());
277 EXPECT_EQ(*fake_file_->metadata->size, logger.results()[0]); 281 EXPECT_EQ(*fake_file_->metadata->size, logger.results()[0]);
278 282
279 std::string buffer_as_string(io_buffer->data(), *fake_file_->metadata->size); 283 std::string buffer_as_string(io_buffer->data(), *fake_file_->metadata->size);
280 EXPECT_EQ(fake_file_->contents, buffer_as_string); 284 EXPECT_EQ(fake_file_->contents, buffer_as_string);
281 } 285 }
282 286
283 TEST_F(FileSystemProviderFileStreamReader, GetLength) { 287 TEST_F(FileSystemProviderFileStreamReader, GetLength) {
284 EventLogger logger; 288 EventLogger logger;
285 289
286 const int64 initial_offset = 0; 290 const int64_t initial_offset = 0;
287 FileStreamReader reader(NULL, file_url_, initial_offset, 291 FileStreamReader reader(NULL, file_url_, initial_offset,
288 *fake_file_->metadata->modification_time); 292 *fake_file_->metadata->modification_time);
289 293
290 const int result = reader.GetLength( 294 const int result = reader.GetLength(
291 base::Bind(&EventLogger::OnGetLength, logger.GetWeakPtr())); 295 base::Bind(&EventLogger::OnGetLength, logger.GetWeakPtr()));
292 EXPECT_EQ(net::ERR_IO_PENDING, result); 296 EXPECT_EQ(net::ERR_IO_PENDING, result);
293 base::RunLoop().RunUntilIdle(); 297 base::RunLoop().RunUntilIdle();
294 298
295 ASSERT_EQ(1u, logger.results().size()); 299 ASSERT_EQ(1u, logger.results().size());
296 EXPECT_LT(0, logger.results()[0]); 300 EXPECT_LT(0, logger.results()[0]);
297 EXPECT_EQ(*fake_file_->metadata->size, logger.results()[0]); 301 EXPECT_EQ(*fake_file_->metadata->size, logger.results()[0]);
298 } 302 }
299 303
300 TEST_F(FileSystemProviderFileStreamReader, GetLength_WrongFile) { 304 TEST_F(FileSystemProviderFileStreamReader, GetLength_WrongFile) {
301 EventLogger logger; 305 EventLogger logger;
302 306
303 const int64 initial_offset = 0; 307 const int64_t initial_offset = 0;
304 FileStreamReader reader(NULL, wrong_file_url_, initial_offset, 308 FileStreamReader reader(NULL, wrong_file_url_, initial_offset,
305 *fake_file_->metadata->modification_time); 309 *fake_file_->metadata->modification_time);
306 310
307 const int result = reader.GetLength( 311 const int result = reader.GetLength(
308 base::Bind(&EventLogger::OnGetLength, logger.GetWeakPtr())); 312 base::Bind(&EventLogger::OnGetLength, logger.GetWeakPtr()));
309 EXPECT_EQ(net::ERR_IO_PENDING, result); 313 EXPECT_EQ(net::ERR_IO_PENDING, result);
310 base::RunLoop().RunUntilIdle(); 314 base::RunLoop().RunUntilIdle();
311 315
312 ASSERT_EQ(1u, logger.results().size()); 316 ASSERT_EQ(1u, logger.results().size());
313 EXPECT_EQ(net::ERR_FILE_NOT_FOUND, logger.results()[0]); 317 EXPECT_EQ(net::ERR_FILE_NOT_FOUND, logger.results()[0]);
314 } 318 }
315 319
316 TEST_F(FileSystemProviderFileStreamReader, GetLength_ModifiedFile) { 320 TEST_F(FileSystemProviderFileStreamReader, GetLength_ModifiedFile) {
317 EventLogger logger; 321 EventLogger logger;
318 322
319 const int64 initial_offset = 0; 323 const int64_t initial_offset = 0;
320 FileStreamReader reader(NULL, file_url_, initial_offset, base::Time::Max()); 324 FileStreamReader reader(NULL, file_url_, initial_offset, base::Time::Max());
321 325
322 const int result = reader.GetLength( 326 const int result = reader.GetLength(
323 base::Bind(&EventLogger::OnGetLength, logger.GetWeakPtr())); 327 base::Bind(&EventLogger::OnGetLength, logger.GetWeakPtr()));
324 EXPECT_EQ(net::ERR_IO_PENDING, result); 328 EXPECT_EQ(net::ERR_IO_PENDING, result);
325 base::RunLoop().RunUntilIdle(); 329 base::RunLoop().RunUntilIdle();
326 330
327 ASSERT_EQ(1u, logger.results().size()); 331 ASSERT_EQ(1u, logger.results().size());
328 EXPECT_EQ(net::ERR_UPLOAD_FILE_CHANGED, logger.results()[0]); 332 EXPECT_EQ(net::ERR_UPLOAD_FILE_CHANGED, logger.results()[0]);
329 } 333 }
330 334
331 TEST_F(FileSystemProviderFileStreamReader, 335 TEST_F(FileSystemProviderFileStreamReader,
332 GetLength_ExpectedModificationTimeNull) { 336 GetLength_ExpectedModificationTimeNull) {
333 EventLogger logger; 337 EventLogger logger;
334 338
335 const int64 initial_offset = 0; 339 const int64_t initial_offset = 0;
336 FileStreamReader reader(NULL, file_url_, initial_offset, base::Time()); 340 FileStreamReader reader(NULL, file_url_, initial_offset, base::Time());
337 341
338 const int result = reader.GetLength( 342 const int result = reader.GetLength(
339 base::Bind(&EventLogger::OnGetLength, logger.GetWeakPtr())); 343 base::Bind(&EventLogger::OnGetLength, logger.GetWeakPtr()));
340 EXPECT_EQ(net::ERR_IO_PENDING, result); 344 EXPECT_EQ(net::ERR_IO_PENDING, result);
341 base::RunLoop().RunUntilIdle(); 345 base::RunLoop().RunUntilIdle();
342 346
343 ASSERT_EQ(1u, logger.results().size()); 347 ASSERT_EQ(1u, logger.results().size());
344 EXPECT_LT(0, logger.results()[0]); 348 EXPECT_LT(0, logger.results()[0]);
345 EXPECT_EQ(*fake_file_->metadata->size, logger.results()[0]); 349 EXPECT_EQ(*fake_file_->metadata->size, logger.results()[0]);
346 } 350 }
347 351
348 } // namespace file_system_provider 352 } // namespace file_system_provider
349 } // namespace chromeos 353 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698