Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Unified Diff: content/renderer/pepper/v8_var_converter.cc

Issue 1547073003: Switch to standard integer types in content/renderer/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/v8_var_converter.h ('k') | content/renderer/pepper/v8_var_converter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/v8_var_converter.cc
diff --git a/content/renderer/pepper/v8_var_converter.cc b/content/renderer/pepper/v8_var_converter.cc
index 536827b0fc520136730152c800052c444259ba48..eff2cabebee372abb8ee76a70533041d2f88fc08 100644
--- a/content/renderer/pepper/v8_var_converter.cc
+++ b/content/renderer/pepper/v8_var_converter.cc
@@ -4,6 +4,9 @@
#include "content/renderer/pepper/v8_var_converter.h"
+#include <stddef.h>
+#include <stdint.h>
+
#include <map>
#include <stack>
#include <string>
@@ -377,7 +380,7 @@ bool V8VarConverter::ToV8Value(const PP_Var& var,
if (did_create && CanHaveChildren(child_var))
stack.push(child_var);
v8::TryCatch try_catch(isolate);
- v8_array->Set(static_cast<uint32>(i), child_v8);
+ v8_array->Set(static_cast<uint32_t>(i), child_v8);
if (try_catch.HasCaught()) {
LOG(ERROR) << "Setter for index " << i << " threw an exception.";
return false;
@@ -516,7 +519,7 @@ bool V8VarConverter::FromV8ValueInternal(
return false;
}
- for (uint32 i = 0; i < v8_array->Length(); ++i) {
+ for (uint32_t i = 0; i < v8_array->Length(); ++i) {
v8::TryCatch try_catch(context->GetIsolate());
v8::Local<v8::Value> child_v8 = v8_array->Get(i);
if (try_catch.HasCaught())
@@ -554,7 +557,7 @@ bool V8VarConverter::FromV8ValueInternal(
}
v8::Local<v8::Array> property_names(v8_object->GetOwnPropertyNames());
- for (uint32 i = 0; i < property_names->Length(); ++i) {
+ for (uint32_t i = 0; i < property_names->Length(); ++i) {
v8::Local<v8::Value> key(property_names->Get(i));
// Extend this test to cover more types as necessary and if sensible.
« no previous file with comments | « content/renderer/pepper/v8_var_converter.h ('k') | content/renderer/pepper/v8_var_converter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698