[Android] Fix GinJavaBridgeMessageFilter registration issue in Java Bridge.

content/browser/android/java/gin_java_bridge_message_filter.h

Index: content/browser/android/java/gin_java_bridge_message_filter.h
diff --git a/content/browser/android/java/gin_java_bridge_message_filter.h b/content/browser/android/java/gin_java_bridge_message_filter.h
index 40165a81d1d6c1c70b8e31f11b7da61ddc4277db..44cf724474b75a502552c6a55a9c070630ecf466 100644
--- a/content/browser/android/java/gin_java_bridge_message_filter.h
+++ b/content/browser/android/java/gin_java_bridge_message_filter.h
@@ -45,6 +45,14 @@ class GinJavaBridgeMessageFilter : public BrowserMessageFilter {
   static scoped_refptr<GinJavaBridgeMessageFilter> FromHost(
       GinJavaBridgeDispatcherHost* host, bool create_if_not_exists);
 
+  // Removes the user data for the |host| from the associated RenderProcessHost.

[mnaganov (inactive), 2015/12/29 16:55:28]

Please change the comment to: "Removes the filter, which triggers its deletion.
Needs to be called when the corresponding RenderProcessHost cleans itself up,
e.g. on renderer process exit."

Your version contains too many unnecessary details :)

[Pritam Nikam, 2015/12/30 12:05:36]

Done.

+  // It need to be called from |host| when communication channel between RPH and
+  // sandbox render process gets exited and eventually triggers the deletion of
+  // this filter. Once new sandbox render process gets up and ready a new
+  // message filter gets created and registered to receive Java bridge IPC
+  // messages.
+  void RemoveUserData(const GinJavaBridgeDispatcherHost* host);

[mnaganov (inactive), 2015/12/29 16:55:28]

Please remove `const` for consistency with the rest of the methods.

[mnaganov (inactive), 2015/12/29 16:55:28]

I would prefer to rename `RemoveUserData` into `RemoveFilter` and make it
static. This way, you will not need to retrieve the filter first in
`RenderProcessGone`. It's perfectly OK to call
`SupportsUserData::RemoveUserData` even if the map contains no corresponding
key.

[Pritam Nikam, 2015/12/30 12:05:36]

Done.

[Pritam Nikam, 2015/12/30 12:05:36]

Done.

+
  private:
   friend class BrowserThread;
   friend class base::DeleteHelper<GinJavaBridgeMessageFilter>;