Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: chrome/browser/translate/translate_manager.cc

Issue 15470004: Translate: display alpha language name with (alpha) suffix (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review #4 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager.cc
diff --git a/chrome/browser/translate/translate_manager.cc b/chrome/browser/translate/translate_manager.cc
index 01c9451163dbc7ffd04df97ce32570d184a0a978..b9162444dbd25fb5608e68c3063c74c9d3e6b287 100644
--- a/chrome/browser/translate/translate_manager.cc
+++ b/chrome/browser/translate/translate_manager.cc
@@ -158,6 +158,14 @@ bool TranslateManager::IsSupportedLanguage(const std::string& language) {
return false;
}
+// static
+bool TranslateManager::IsAlphaLanguage(const std::string& language) {
+ if (GetInstance()->language_list_.get())
+ return GetInstance()->language_list_->IsAlphaLanguage(language);
+ NOTREACHED();
+ return false;
+}
+
void TranslateManager::Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) {
@@ -730,8 +738,6 @@ void TranslateManager::InitAcceptLanguages(PrefService* prefs) {
void TranslateManager::FetchLanguageListFromTranslateServer(
PrefService* prefs) {
- DCHECK(language_list_.get());
-
// We don't want to do this when translate is disabled.
DCHECK(prefs != NULL);
if (CommandLine::ForCurrentProcess()->HasSwitch(
@@ -742,6 +748,8 @@ void TranslateManager::FetchLanguageListFromTranslateServer(
if (language_list_.get())
language_list_->RequestLanguageList();
+ else
+ NOTREACHED();
}
void TranslateManager::CleanupPendingUlrFetcher() {

Powered by Google App Engine
This is Rietveld 408576698