Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2689)

Unified Diff: chrome/browser/translate/translate_language_list.h

Issue 15470004: Translate: display alpha language name with (alpha) suffix (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review #4 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_language_list.h
diff --git a/chrome/browser/translate/translate_language_list.h b/chrome/browser/translate/translate_language_list.h
index c9178648258474ebd62f0f51efbd3e46d38704b0..c6d458c1bc91171867d136734d74bacf6664ca31 100644
--- a/chrome/browser/translate/translate_language_list.h
+++ b/chrome/browser/translate/translate_language_list.h
@@ -38,7 +38,9 @@ class TranslateLanguageList : public net::URLFetcherDelegate {
// Returns true if |language| is supported by the translation server.
bool IsSupportedLanguage(const std::string& language);
- // TODO(toyoshim): Add IsSupportedAlphaLanguage() here.
+ // Returns true if |language| is supported by the translation server as a
+ // alpha language.
+ bool IsAlphaLanguage(const std::string& language);
// Fetches the language list from the translate server. It will not retry
// more than kMaxRetryLanguageListFetch times.
@@ -49,15 +51,18 @@ class TranslateLanguageList : public net::URLFetcherDelegate {
static const char kTargetLanguagesKey[];
private:
- // Parses |language_list| and fills |supported_languages_| with the list of
- // languages that the translate server can translate to and from.
- void SetSupportedLanguages(const std::string& language_list);
-
// The languages supported by the translation server.
std::set<std::string> supported_languages_;
+ // The alpha languages supported by the translation server.
+ std::set<std::string> supported_alpha_languages_;
+
// An URLFetcher instance to fetch a server providing supported language list.
- scoped_ptr<net::URLFetcher> url_fetcher_;
+ scoped_ptr<net::URLFetcher> language_list_fetcher_;
+
+ // An URLFetcher instance to fetch a server providing supported alpha language
+ // list.
+ scoped_ptr<net::URLFetcher> alpha_language_list_fetcher_;
DISALLOW_COPY_AND_ASSIGN(TranslateLanguageList);
};

Powered by Google App Engine
This is Rietveld 408576698