Translate: display alpha language name with (alpha) suffix

chrome/browser/translate/translate_language_list.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_TRANSLATE_TRANSLATE_LANGUAGE_LIST_H_
 #define CHROME_BROWSER_TRANSLATE_TRANSLATE_LANGUAGE_LIST_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 20 matching lines @@
   // translate to and from.
   void GetSupportedLanguages(std::vector<std::string>* languages);
 
   // Returns the language code that can be used with the Translate method for a
   // specified |chrome_locale|.
   std::string GetLanguageCode(const std::string& chrome_locale);
 
   // Returns true if |language| is supported by the translation server.
   bool IsSupportedLanguage(const std::string& language);
 
-  // TODO(toyoshim): Add IsSupportedAlphaLanguage() here.
+  // Returns true if |language| is supported by the translation server as a
+  // alpha language.
+  bool IsAlphaLanguage(const std::string& language);
 
   // Fetches the language list from the translate server. It will not retry
   // more than kMaxRetryLanguageListFetch times.
   void RequestLanguageList();
 
   // static const values shared with our browser tests.
   static const char kLanguageListCallbackName[];
   static const char kTargetLanguagesKey[];
 
  private:
   // Parses |language_list| and fills |supported_languages_| with the list of
   // languages that the translate server can translate to and from.
   void SetSupportedLanguages(const std::string& language_list);
 
+  // Fetches the language list. If |alpha| is set, it requests a language list
+  // including alpha languages.
+  void FetchLanguageList(bool alpha);
+
   // The languages supported by the translation server.
   std::set<std::string> supported_languages_;
 
+  // The alpha languages supported by the translation server.
+  std::set<std::string> supported_alpha_languages_;
+
   // An URLFetcher instance to fetch a server providing supported language list.
   scoped_ptr<net::URLFetcher> url_fetcher_;
 
+  // Flag if |ufl_fetcher_| is requesting a language list including alpha

[MAD, 2013/05/29 14:09:32]

I usually try to avoid such flags, it's a bit risky. For example, you never
reset it to false after setting it to true, so if we would ever need to fetch
for languages again, we may have bugs.

I would prefer that you subclass the URLFetcher and add the boolean in there. It
will make things clearer.

[Takashi Toyoshima, 2013/05/30 06:25:31]

Done.

+  // languages.
+  bool requesting_alpha_;
+
   DISALLOW_COPY_AND_ASSIGN(TranslateLanguageList);
 };
 
 #endif  // CHROME_BROWSER_TRANSLATE_TRANSLATE_LANGUAGE_LIST_H_