Site Settings: Give each category its own route.

chrome/browser/resources/settings/site_settings/site_settings_category.js

Index: chrome/browser/resources/settings/site_settings/site_settings_category.js
diff --git a/chrome/browser/resources/settings/site_settings/site_settings_category.js b/chrome/browser/resources/settings/site_settings/site_settings_category.js
index 01b764c709e7768fc15c66762547c27bbac9b9b4..606254aac7681b65945b85842e5269f8cc35fa0e 100644
--- a/chrome/browser/resources/settings/site_settings/site_settings_category.js
+++ b/chrome/browser/resources/settings/site_settings/site_settings_category.js
@@ -62,11 +62,16 @@ Polymer({
   ],
 
   ready: function() {
-    // TODO(finnur): Handle dynamic routes, so that we can link directly into
-    // individual categories without having to first stop by the site settings
-    // page to select a category.
     this.$.blockList.categorySubtype = settings.PermissionValues.BLOCK;
     this.$.allowList.categorySubtype = settings.PermissionValues.ALLOW;
+
+    // See if the URL contains a specific category (only happens if the user
+    // navigates directly to the category page).
+    var urlParts = window.location.href.split('/');
+    var displayName = urlParts[urlParts.length - 1];
+    var category = this.computeCategoryFromDisplayName(displayName);

[tommycli, 2016/01/04 18:12:09]

same comment as before regarding display name

[Finnur, 2016/01/05 15:54:07]

You prefer that to be named computeCategoryFromUrlPart?

[tommycli, 2016/01/05 18:28:58]

Actually I think this code is probably just unneeded per our discussion within
settings_router.js

+    if (category != -1)
+      this.category = category;

[tommycli, 2016/01/04 18:12:09]

setting this.category using the final part of the URL seems fragile and
unpolymeric.

It seems like it would be better if it was passed in as a attribute, i.e.

<site-settings-category prefs="{{prefs}}" category="cookies">
</site-settings-category>

[Finnur, 2016/01/05 15:54:07]

I am already doing that (setting the category), through the privacy_page.html.
It binds |category| with its own |selectedCategory| variable, which is set in
site_settings_page.js.

This code is to handle the case where you refresh the page when displaying a
certain category. At that point, all we have is the URL and the |category|
variable is undefined. In other words: This code links up the pieces as they
were before refreshing.

[tommycli, 2016/01/05 18:28:58]

Oh I see.

If you define the routes as suggested in settings_router.html, the refresh part
should be taken care of automatically (without needing this code)

   },
 
   /**
@@ -84,7 +89,7 @@ Polymer({
                               settings.PermissionValues.ALLOW :
                               settings.PermissionValues.BLOCK);
         break;
-      case settings.ContentSettingsTypes.NOTIFICATION:
+      case settings.ContentSettingsTypes.NOTIFICATIONS:
       case settings.ContentSettingsTypes.GEOLOCATION:
       case settings.ContentSettingsTypes.CAMERA:
       case settings.ContentSettingsTypes.MIC: