chrome/browser/resources/settings/site_settings/site_details.js - Issue 1546993003: Site Settings: Give each category its own route.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_details.js

Issue 1546993003: Site Settings: Give each category its own route. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/site_settings/site_details.js

diff --git a/chrome/browser/resources/settings/site_settings/site_details.js b/chrome/browser/resources/settings/site_settings/site_details.js

index cc6d5616cf136acb489007c5c4599b4b3e61bb03..a6a8db7bccd77c5cc7efe83b5ed76db48c90c85d 100644

--- a/chrome/browser/resources/settings/site_settings/site_details.js

+++ b/chrome/browser/resources/settings/site_settings/site_details.js

@@ -47,7 +47,7 @@ Polymer({

this.$.javascript.category = settings.ContentSettingsTypes.JAVASCRIPT;

this.$.popups.category = settings.ContentSettingsTypes.POPUPS;

this.$.geolocation.category = settings.ContentSettingsTypes.GEOLOCATION;

- this.$.notification.category = settings.ContentSettingsTypes.NOTIFICATION;

+ this.$.notification.category = settings.ContentSettingsTypes.NOTIFICATIONS;

this.$.fullscreen.category = settings.ContentSettingsTypes.FULLSCREEN;

this.$.camera.category = settings.ContentSettingsTypes.CAMERA;

this.$.mic.category = settings.ContentSettingsTypes.MIC;