Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6178)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.html

Issue 1546993003: Site Settings: Give each category its own route. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/privacy_page/privacy_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index 7d32b89b6f401a97959fea78d0e8850014f2245c..254e19746abf0501168bcc6bd0565eef3d29018c 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -9,6 +9,7 @@
<link rel="import" href="chrome://md-settings/controls/settings_checkbox.html">
<link rel="import" href="chrome://md-settings/settings_page/settings_animated_pages.html">
<link rel="import" href="chrome://md-settings/settings_page/settings_subheader.html">
+<link rel="import" href="chrome://md-settings/site_settings/constants.html">
<link rel="import" href="chrome://md-settings/site_settings_page/site_settings_page.html">
<dom-module id="settings-privacy-page">
@@ -99,17 +100,92 @@
<settings-subheader i18n-values="page-title:siteSettings">
</settings-subheader>
<settings-site-settings-page current-route="{{currentRoute}}"
- prefs="{{prefs}}" category-selected="{{categorySelected}}">
+ prefs="{{prefs}}">
</settings-site-settings-page>
</neon-animatable>
- <neon-animatable id="site-settings-category">
+
+ <neon-animatable id="site-settings-category-camera">
+ <settings-subheader i18n-values="page-title:siteSettings">
+ </settings-subheader>
+ <site-settings-category
+ selected-origin="{{originSelected}}" prefs="{{prefs}}"
+ current-route="{{currentRoute}}"
+ category="{{ContentSettingsTypes.CAMERA}}">
+ </site-settings-category>
+ </neon-animatable>
+ <neon-animatable id="site-settings-category-cookies">
+ <settings-subheader i18n-values="page-title:siteSettings">
+ </settings-subheader>
+ <site-settings-category
+ selected-origin="{{originSelected}}" prefs="{{prefs}}"
+ current-route="{{currentRoute}}"
+ category="{{ContentSettingsTypes.COOKIES}}">
+ </site-settings-category>
+ </neon-animatable>
+ <neon-animatable id="site-settings-category-fullscreen">
+ <settings-subheader i18n-values="page-title:siteSettings">
+ </settings-subheader>
+ <site-settings-category
+ selected-origin="{{originSelected}}" prefs="{{prefs}}"
+ current-route="{{currentRoute}}"
+ category="{{ContentSettingsTypes.FULLSCREEN}}">
+ </site-settings-category>
+ </neon-animatable>
+ <neon-animatable id="site-settings-category-images">
+ <settings-subheader i18n-values="page-title:siteSettings">
+ </settings-subheader>
+ <site-settings-category
+ selected-origin="{{originSelected}}" prefs="{{prefs}}"
+ current-route="{{currentRoute}}"
+ category="{{ContentSettingsTypes.IMAGES}}">
+ </site-settings-category>
+ </neon-animatable>
+ <neon-animatable id="site-settings-category-location">
<settings-subheader i18n-values="page-title:siteSettings">
</settings-subheader>
<site-settings-category
selected-origin="{{originSelected}}" prefs="{{prefs}}"
- current-route="{{currentRoute}}" category="{{categorySelected}}">
+ current-route="{{currentRoute}}"
+ category="{{ContentSettingsTypes.GEOLOCATION}}">
</site-settings-category>
</neon-animatable>
+ <neon-animatable id="site-settings-category-javascript">
+ <settings-subheader i18n-values="page-title:siteSettings">
+ </settings-subheader>
+ <site-settings-category
+ selected-origin="{{originSelected}}" prefs="{{prefs}}"
+ current-route="{{currentRoute}}"
+ category="{{ContentSettingsTypes.JAVASCRIPT}}">
+ </site-settings-category>
+ </neon-animatable>
+ <neon-animatable id="site-settings-category-microphone">
+ <settings-subheader i18n-values="page-title:siteSettings">
+ </settings-subheader>
+ <site-settings-category
+ selected-origin="{{originSelected}}" prefs="{{prefs}}"
+ current-route="{{currentRoute}}"
+ category="{{ContentSettingsTypes.MIC}}">
+ </site-settings-category>
+ </neon-animatable>
+ <neon-animatable id="site-settings-category-notifications">
+ <settings-subheader i18n-values="page-title:siteSettings">
+ </settings-subheader>
+ <site-settings-category
+ selected-origin="{{originSelected}}" prefs="{{prefs}}"
+ current-route="{{currentRoute}}"
+ category="{{ContentSettingsTypes.NOTIFICATIONS}}">
+ </site-settings-category>
+ </neon-animatable>
+ <neon-animatable id="site-settings-category-popups">
+ <settings-subheader i18n-values="page-title:siteSettings">
+ </settings-subheader>
+ <site-settings-category
+ selected-origin="{{originSelected}}" prefs="{{prefs}}"
+ current-route="{{currentRoute}}"
+ category="{{ContentSettingsTypes.POPUPS}}">
+ </site-settings-category>
+ </neon-animatable>
+
<neon-animatable id="site-details">
<site-details prefs="{{prefs}}" origin="{{originSelected}}">
</site-details>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/privacy_page/privacy_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698