Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: chrome/browser/resources/settings/site_settings/site_list.js

Issue 1546993003: Site Settings: Give each category its own route. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-site-list' shows a list of Allowed and Blocked sites for a given 7 * 'settings-site-list' shows a list of Allowed and Blocked sites for a given
8 * category. 8 * category.
9 * 9 *
10 * Example: 10 * Example:
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 return { 93 return {
94 allowAction: loadTimeData.getString('siteSettingsActionAllow'), 94 allowAction: loadTimeData.getString('siteSettingsActionAllow'),
95 blockAction: loadTimeData.getString('siteSettingsActionBlock'), 95 blockAction: loadTimeData.getString('siteSettingsActionBlock'),
96 resetAction: loadTimeData.getString('siteSettingsActionReset'), 96 resetAction: loadTimeData.getString('siteSettingsActionReset'),
97 }; 97 };
98 }, 98 },
99 }, 99 },
100 }, 100 },
101 101
102 observers: [ 102 observers: [
103 'onCategoryChanged_(prefs.profile.content_settings.exceptions.*, category)', 103 'onCategoryChanged_(prefs.profile.content_settings.exceptions.*, ' +
104 'category, categorySubtype)',
104 ], 105 ],
105 106
106 ready: function() { 107 ready: function() {
107 CrSettingsPrefs.initialized.then(function() { 108 CrSettingsPrefs.initialized.then(function() {
108 this.initialize_(); 109 this.initialize_();
109 }.bind(this)); 110 }.bind(this));
110 }, 111 },
111 112
112 /** 113 /**
113 * One-time initialization routines for this class. 114 * One-time initialization routines for this class.
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 * Returns the icon to use for a given site. 266 * Returns the icon to use for a given site.
266 * @param {string} url The url of the site to fetch the icon for. 267 * @param {string} url The url of the site to fetch the icon for.
267 * @private 268 * @private
268 */ 269 */
269 computeSiteIcon_: function(url) { 270 computeSiteIcon_: function(url) {
270 // TODO(finnur): For now, we're returning a placeholder image for each site 271 // TODO(finnur): For now, we're returning a placeholder image for each site
271 // but the actual favicon for each site will need to be returned. 272 // but the actual favicon for each site will need to be returned.
272 return 'communication:message'; 273 return 'communication:message';
273 }, 274 },
274 }); 275 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698