Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_router.js

Issue 1546993003: Site Settings: Give each category its own route. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-router' is a simple router for settings. Its responsibilities: 7 * 'settings-router' is a simple router for settings. Its responsibilities:
8 * - Update the URL when the routing state changes. 8 * - Update the URL when the routing state changes.
9 * - Initialize the routing state with the initial URL. 9 * - Initialize the routing state with the initial URL.
10 * - Process and validate all routing state changes. 10 * - Process and validate all routing state changes.
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 subpageTitles: ['manageCertificates'], 135 subpageTitles: ['manageCertificates'],
136 }, 136 },
137 { 137 {
138 url: '/siteSettings', 138 url: '/siteSettings',
139 page: 'advanced', 139 page: 'advanced',
140 section: 'privacy', 140 section: 'privacy',
141 subpage: ['site-settings'], 141 subpage: ['site-settings'],
142 subpageTitles: ['siteSettings'], 142 subpageTitles: ['siteSettings'],
143 }, 143 },
144 { 144 {
145 url: '/siteSettings/category', 145 url: '/siteSettings/category/camera',
146 page: 'advanced', 146 page: 'advanced',
147 section: 'privacy', 147 section: 'privacy',
148 subpage: ['site-settings', 'site-settings-category'], 148 subpage: ['site-settings', 'site-settings-category-camera'],
149 subpageTitles: ['siteSettings', 'siteSettingsCategoryPageTitle'], 149 subpageTitles: ['siteSettings', 'siteSettingsCamera'],
150 },
151 {
152 url: '/siteSettings/category/cookies',
153 page: 'advanced',
154 section: 'privacy',
155 subpage: ['site-settings', 'site-settings-category-cookies'],
156 subpageTitles: ['siteSettings', 'siteSettingsCategoryCookies'],
157 },
158 {
159 url: '/siteSettings/category/fullscreen',
160 page: 'advanced',
161 section: 'privacy',
162 subpage: ['site-settings', 'site-settings-category-fullscreen'],
163 subpageTitles: ['siteSettings', 'siteSettingsCategoryFullscreen'],
164 },
165 {
166 url: '/siteSettings/category/images',
167 page: 'advanced',
168 section: 'privacy',
169 subpage: ['site-settings', 'site-settings-category-images'],
170 subpageTitles: ['siteSettings', 'siteSettingsCategoryImages'],
171 },
172 {
173 url: '/siteSettings/category/location',
174 page: 'advanced',
175 section: 'privacy',
176 subpage: ['site-settings', 'site-settings-category-location'],
177 subpageTitles: ['siteSettings', 'siteSettingsCategoryLocation'],
178 },
179 {
180 url: '/siteSettings/category/javascript',
181 page: 'advanced',
182 section: 'privacy',
183 subpage: ['site-settings', 'site-settings-category-javascript'],
184 subpageTitles: ['siteSettings', 'siteSettingsCategoryJavascript'],
185 },
186 {
187 url: '/siteSettings/category/microphone',
188 page: 'advanced',
189 section: 'privacy',
190 subpage: ['site-settings', 'site-settings-category-microphone'],
191 subpageTitles: ['siteSettings', 'siteSettingsCategoryMicrophone'],
192 },
193 {
194 url: '/siteSettings/category/notifications',
195 page: 'advanced',
196 section: 'privacy',
197 subpage: ['site-settings', 'site-settings-category-notifications'],
198 subpageTitles: ['siteSettings', 'siteSettingsCategoryNotifications'],
199 },
200 {
201 url: '/siteSettings/category/popups',
202 page: 'advanced',
203 section: 'privacy',
204 subpage: ['site-settings', 'site-settings-category-popups'],
205 subpageTitles: ['siteSettings', 'siteSettingsCategoryPopups'],
150 }, 206 },
151 { 207 {
152 url: '/siteSettings/category/details', 208 url: '/siteSettings/category/details',
153 page: 'advanced', 209 page: 'advanced',
154 section: 'privacy', 210 section: 'privacy',
155 subpage: ['site-settings', 'site-settings-category', 'site-details'], 211 subpage: ['site-settings', 'site-settings-category', 'site-details'],
156 subpageTitles: ['siteSettings', 'siteSettingsCategoryPageTitle', 212 subpageTitles: ['siteSettings', 'siteSettingsCategoryPageTitle',
157 'siteSettingsSiteDetailsPageTitle'], 213 'siteSettingsSiteDetailsPageTitle'],
158 }, 214 },
159 { 215 {
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 history.replaceState(historicState, null); 314 history.replaceState(historicState, null);
259 } 315 }
260 316
261 return; 317 return;
262 } 318 }
263 } 319 }
264 320
265 assertNotReached('Route not found: ' + JSON.stringify(newRoute)); 321 assertNotReached('Route not found: ' + JSON.stringify(newRoute));
266 }, 322 },
267 }); 323 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698