Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1546973003: MIPS: Remove clang-format-off from assembler tests. (Closed)

Created:
4 years, 12 months ago by paul.l...
Modified:
4 years, 12 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Remove clang-format-off from assembler tests. Per request in https://codereview.chromium.org/1047213002/ These files will continue to have a lot of churn in next two months as we finish support for MIPS r6 instruction set. When things settle down, we will do a clang-format --full to clean them up. For now, we'd prefer to be able to do easy diffs, and will do incremental re-formats as we make changes. BUG= Committed: https://crrev.com/ac33eaba10644a9f29095f2a56b98914bbbda047 Cr-Commit-Position: refs/heads/master@{#33038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M test/cctest/test-assembler-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
paul.l...
Sorry it took so long for this trivial change. PTAL.
4 years, 12 months ago (2015-12-24 04:46:48 UTC) #2
ivica.bogosavljevic
On 2015/12/24 04:46:48, paul.l... wrote: > Sorry it took so long for this trivial change. ...
4 years, 12 months ago (2015-12-24 08:41:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546973003/1
4 years, 12 months ago (2015-12-24 13:58:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-24 14:17:19 UTC) #6
commit-bot: I haz the power
4 years, 12 months ago (2015-12-24 14:18:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac33eaba10644a9f29095f2a56b98914bbbda047
Cr-Commit-Position: refs/heads/master@{#33038}

Powered by Google App Engine
This is Rietveld 408576698