Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1546943002: dart2js: Update test status files for the CPS backend. (Closed)

Created:
5 years ago by Kevin Millikin (Google)
Modified:
5 years ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Update test status files for the CPS backend. After inlining, test expectations have changed. A few tests have starting unexpectedly passing --- this could be because inlining implements the correct semantics, or the could be passing for the wrong reason. In any case, the underlying bug in the compiler has not been fixed. I will look into all these issues after the Christmas holidays. BUG= Committed: https://github.com/dart-lang/sdk/commit/b5aac5b951316d2a21de7a16000a2cfcc9c68aed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M pkg/pkg.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Kevin Millikin (Google)
5 years ago (2015-12-23 11:25:35 UTC) #2
Kevin Millikin (Google)
On 2015/12/23 11:25:35, Kevin Millikin (Google) wrote: TBR'd.
5 years ago (2015-12-23 11:25:51 UTC) #3
Kevin Millikin (Google)
Committed patchset #1 (id:1) manually as b5aac5b951316d2a21de7a16000a2cfcc9c68aed (presubmit successful).
5 years ago (2015-12-23 11:26:10 UTC) #5
karlklose
5 years ago (2015-12-23 12:24:47 UTC) #6
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698