Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1546833002: [DevTools] Add rulers to Device Mode. (Closed)

Created:
5 years ago by dgozman
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Add rulers to Device Mode. BUG=540864 Committed: https://crrev.com/147c8b632c68b7d7c28be1e0fd4cf3db6608b091 Cr-Commit-Position: refs/heads/master@{#368163}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -47 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 1 15 chunks +179 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/MediaQueryInspector.js View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/deviceModeView.css View 1 chunk +103 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dgozman
Take a look please. Screenshot: http://pasteboard.co/eDu2euB.png
5 years ago (2015-12-23 00:47:26 UTC) #2
pfeldman
lgtm
4 years, 11 months ago (2016-01-04 21:18:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546833002/1
4 years, 11 months ago (2016-01-04 21:19:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/112396) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 11 months ago (2016-01-04 21:22:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546833002/20001
4 years, 11 months ago (2016-01-07 20:05:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-07 21:38:21 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 21:39:34 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/147c8b632c68b7d7c28be1e0fd4cf3db6608b091
Cr-Commit-Position: refs/heads/master@{#368163}

Powered by Google App Engine
This is Rietveld 408576698