src/compiler/bytecode-graph-builder.h - Issue 1546683002: [Interpreter] Add support for jumps using constants with wide operands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/bytecode-graph-builder.h

Issue 1546683002: [Interpreter] Add support for jumps using constants with wide operands. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rationalize jumps in bytecode-graph-builder.cc. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/bytecode-graph-builder.h

diff --git a/src/compiler/bytecode-graph-builder.h b/src/compiler/bytecode-graph-builder.h

index 6770b5de142700f8beed789fd11212556a92300f..4447a568274c64d45586f99b5a884a86d24202d6 100644

--- a/src/compiler/bytecode-graph-builder.h

+++ b/src/compiler/bytecode-graph-builder.h

@@ -160,10 +160,8 @@ class BytecodeGraphBuilder {

void BuildJump(int source_offset, int target_offset);

void BuildJump();

void BuildConditionalJump(Node* condition);

- // Helpers for building conditions for conditional jumps.

- Node* BuildCondition(Node* comperand);

- Node* BuildToBooleanCondition(Node* comperand);

+ void BuildJumpIfEqual(Node* comperand);

+ void BuildJumpIfToBooleanEqual(Node* boolean_comperand);

// Constructing merge and loop headers.

void MergeEnvironmentsOfBackwardBranches(int source_offset,

« no previous file with comments | « BUILD.gn ('k') | src/compiler/bytecode-graph-builder.cc » ('j') | src/interpreter/bytecode-array-builder.cc » ('J')