src/interpreter/bytecode-array-iterator.cc - Issue 1546683002: [Interpreter] Add support for jumps using constants with wide operands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-array-iterator.cc

Issue 1546683002: [Interpreter] Add support for jumps using constants with wide operands. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Incorporate comments on patchset 13. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter/bytecode-array-iterator.cc

diff --git a/src/interpreter/bytecode-array-iterator.cc b/src/interpreter/bytecode-array-iterator.cc

index 9af4c5a29ab2c7f7a40859ce3e4e510dbc63a9a4..344fbc3ab269ea6317f3e36da1385980d465cf3d 100644

--- a/src/interpreter/bytecode-array-iterator.cc

+++ b/src/interpreter/bytecode-array-iterator.cc

@@ -107,7 +107,8 @@ int BytecodeArrayIterator::GetJumpTargetOffset() const {

if (interpreter::Bytecodes::IsJumpImmediate(bytecode)) {

int relative_offset = GetImmediateOperand(0);

return current_offset() + relative_offset;

- } else if (interpreter::Bytecodes::IsJumpConstant(bytecode)) {

+ } else if (interpreter::Bytecodes::IsJumpConstant(bytecode) ||

+ interpreter::Bytecodes::IsJumpConstantWide(bytecode)) {

Smi* smi = Smi::cast(*GetConstantForIndexOperand(0));

return current_offset() + smi->value();

} else {

« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/bytecodes.h » ('j') | no next file with comments »