Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: chrome/common/chrome_paths_win.cc

Issue 1546673002: Add the crash client ID to the uninstall URL params. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: GN build fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/chrome_paths_internal.h ('k') | chrome/installer/util/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/chrome_paths_internal.h" 5 #include "chrome/common/chrome_paths_internal.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <knownfolders.h> 8 #include <knownfolders.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #include <shlobj.h> 10 #include <shlobj.h>
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 #if !defined(DISABLE_NACL) 111 #if !defined(DISABLE_NACL)
112 if (process_type == switches::kNaClBrokerProcess || 112 if (process_type == switches::kNaClBrokerProcess ||
113 process_type == switches::kNaClLoaderProcess) { 113 process_type == switches::kNaClLoaderProcess) {
114 return true; 114 return true;
115 } 115 }
116 #endif 116 #endif
117 117
118 return false; 118 return false;
119 } 119 }
120 120
121 bool GetDefaultCrashDumpLocation(base::FilePath* crash_dir) {
122 // In order to be able to start crash handling very early, we do not rely on
Nico 2016/01/13 21:36:29 shouldn't this have an #if defined(OS_WIN) too?
grt (UTC plus 2) 2016/01/14 01:44:41 It's inherently OS_WIN on account of it being in a
123 // chrome's PathService entries (for DIR_CRASH_DUMPS) being available on
124 // Windows. See https://crbug.com/564398.
125 if (!GetDefaultUserDataDirectory(crash_dir))
126 return false;
127 *crash_dir = crash_dir->Append(FILE_PATH_LITERAL("Crashpad"));
128 return true;
129 }
130
121 } // namespace chrome 131 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/common/chrome_paths_internal.h ('k') | chrome/installer/util/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698