[Interpreter] Updates load/store global and named property to accept variable name.

[Interpreter] Updates load/store global and named property to accept variable name.

Changes LoadGlobal, StoreGlobal, LoadNamedProperty, and StoreNamedProperty to accept
the name of variable instead of index into the constant pool entry. Also made
GetConstantPoolEntry as a private function since it is no longer used outside of
BytecodeArrayBuilder.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/87dee75e1f37caec406ce02d5acf14374fc7d321
Cr-Commit-Position: refs/heads/master@{#33020}

[mythria, 2015-12-22 14:52:30]

Description was changed from

==========
[Interpreter] Updates load/store global and named property to accept variable
name.

Changes LoadGlobal, StoreGlobal, LoadNamedProperty, StoreNamedProperty to accept
the name of variable instead of index into the constant pool entry. Also made
GetConstantPoolEntry as a private function since it is no longer used outside of
BytecodeArrayBuilder.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Updates load/store global and named property to accept variable
name.

Changes LoadGlobal, StoreGlobal, LoadNamedProperty, and StoreNamedProperty to
accept
the name of variable instead of index into the constant pool entry. Also made
GetConstantPoolEntry as a private function since it is no longer used outside of
BytecodeArrayBuilder.

BUG=v8:4280
LOG=N
==========

[mythria, 2015-12-22 14:54:53]

mythria@chromium.org changed reviewers:
+ oth@chromium.org

[mythria, 2015-12-22 14:54:54]

Could you please review my changes. This is to address Ross's comments in this
cl
https://codereview.chromium.org/1524803003/diff/40001/src/interpreter/bytecod...

Thanks,
Mythri

[oth, 2015-12-22 15:53:24]

On 2015/12/22 14:54:54, mythria wrote:
> Could you please review my changes. This is to address Ross's comments in this
> cl
>
https://codereview.chromium.org/1524803003/diff/40001/src/interpreter/bytecod...
> 
> Thanks,
> Mythri

lgtm, makes the code much cleaner.

[mythria, 2015-12-23 09:10:35]

The CQ bit was checked by mythria@chromium.org

[commit-bot: I haz the power, 2015-12-23 09:10:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1546643002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1546643002/1

[commit-bot: I haz the power, 2015-12-23 09:13:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-23 09:13:03]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9237)

[mythria, 2015-12-23 09:24:02]

mythria@chromium.org changed reviewers:
+ bmeurer@chromium.org

[mythria, 2015-12-23 09:24:02]

Hi benedikt, could you please take a look. This change is internal to
interpreter to clean up some code. I updated few tests as a part of this change.
I need an lgtm from owners of test. Sorry, for bothering you. Ross is on
vacation :)

[Benedikt Meurer, 2015-12-23 09:30:50]

LGTM (rubberstamped)

[mythria, 2015-12-23 09:31:48]

The CQ bit was checked by mythria@chromium.org

[commit-bot: I haz the power, 2015-12-23 09:32:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1546643002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1546643002/1

[commit-bot: I haz the power, 2015-12-23 09:34:07]

Description was changed from

==========
[Interpreter] Updates load/store global and named property to accept variable
name.

Changes LoadGlobal, StoreGlobal, LoadNamedProperty, and StoreNamedProperty to
accept
the name of variable instead of index into the constant pool entry. Also made
GetConstantPoolEntry as a private function since it is no longer used outside of
BytecodeArrayBuilder.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Updates load/store global and named property to accept variable
name.

Changes LoadGlobal, StoreGlobal, LoadNamedProperty, and StoreNamedProperty to
accept
the name of variable instead of index into the constant pool entry. Also made
GetConstantPoolEntry as a private function since it is no longer used outside of
BytecodeArrayBuilder.

BUG=v8:4280
LOG=N
==========

[commit-bot: I haz the power, 2015-12-23 09:34:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-23 09:34:51]

Description was changed from

==========
[Interpreter] Updates load/store global and named property to accept variable
name.

Changes LoadGlobal, StoreGlobal, LoadNamedProperty, and StoreNamedProperty to
accept
the name of variable instead of index into the constant pool entry. Also made
GetConstantPoolEntry as a private function since it is no longer used outside of
BytecodeArrayBuilder.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Updates load/store global and named property to accept variable
name.

Changes LoadGlobal, StoreGlobal, LoadNamedProperty, and StoreNamedProperty to
accept
the name of variable instead of index into the constant pool entry. Also made
GetConstantPoolEntry as a private function since it is no longer used outside of
BytecodeArrayBuilder.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/87dee75e1f37caec406ce02d5acf14374fc7d321
Cr-Commit-Position: refs/heads/master@{#33020}
==========

[commit-bot: I haz the power, 2015-12-23 09:34:52]

Patchset 1 (id:??) landed as
https://crrev.com/87dee75e1f37caec406ce02d5acf14374fc7d321
Cr-Commit-Position: refs/heads/master@{#33020}