Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: ios/web/web_state/ui/crw_wk_web_view_web_controller.mm

Issue 1546603005: [ios] Make sure that |didFinishNavigation| is signalled for fast goBack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed spelling Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_wk_web_view_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm b/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm
index 2c2b1e320076d2a769b891cf9fb8d4b848cc3cbd..040f61392d254a71b52580c85759dd61466c7a59 100644
--- a/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm
+++ b/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm
@@ -1616,6 +1616,12 @@ WKWebViewErrorSource WKWebViewErrorSourceFromError(NSError* error) {
[self addActivityIndicatorTask];
} else {
[self clearActivityIndicatorTasks];
+ if ([self currentBackForwardListItemHolder]->navigation_type() ==
+ WKNavigationTypeBackForward) {
+ // A fast back/forward may not call |webView:didFinishNavigation:|, so
+ // finishing the navigation should be signalled explicitly.
+ [self didFinishNavigation];
+ }
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698