Ensure zoom level is not updated if main frame is WebRemoteFrame.

Ensure zoom level is not updated if main frame is WebRemoteFrame.

When swapped out RenderFrame is not used, the RenderView/WebView does not
have a main WebLocalFrame. This CL ensures the WebView code is not called
in such cases until it is updated to properly handle out-of-process iframes.

BUG=571603
Committed: https://crrev.com/eaa6adc9f2b8463b7f5859e3b9faffecdd5225f1
Cr-Commit-Position: refs/heads/master@{#366698}

[nasko, 2015-12-22 18:08:55]

nasko@chromium.org changed reviewers:
+ dcheng@chromium.org

[nasko, 2015-12-22 18:08:56]

Hey Daniel,
Can you look over the changes I made to the leak detector? The parameter was
unused and it was causing a DCHECK when RenderViewTest is cleaning up a
RenderView with remote main frame.
Thanks in advance!
Nasko

[dcheng, 2015-12-22 18:27:36]

https://codereview.chromium.org/1546603003/diff/1/content/renderer/render_vie...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/1546603003/diff/1/content/renderer/render_vie...
content/renderer/render_view_impl.cc:3725: if
(webview()->mainFrame()->isWebRemoteFrame())
Is this a temporary workaround? Or is this one of those 'view method needs to
move to widget' things? Or some other category?

[nasko, 2015-12-22 18:31:07]

https://codereview.chromium.org/1546603003/diff/1/content/renderer/render_vie...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/1546603003/diff/1/content/renderer/render_vie...
content/renderer/render_view_impl.cc:3725: if
(webview()->mainFrame()->isWebRemoteFrame())
On 2015/12/22 18:27:36, dcheng wrote:
> Is this a temporary workaround? Or is this one of those 'view method needs to
> move to widget' things? Or some other category?

The whole zoom feature needs to be updated for out-of-process iframes, which
will move this around. I don't expect it to stay in RenderView and will move to
RenderFrame or possibly the equivalent of Page.

In the meantime, without out-of-process iframes, but with swapped out disabled,
we have a race where the zoom level IPC is sent from the browser right after the
swap out, which causes crashes.

[dcheng, 2015-12-22 18:35:13]

lgtm

https://codereview.chromium.org/1546603003/diff/1/content/renderer/render_vie...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/1546603003/diff/1/content/renderer/render_vie...
content/renderer/render_view_impl.cc:3725: if
(webview()->mainFrame()->isWebRemoteFrame())
On 2015/12/22 at 18:31:06, nasko wrote:
> On 2015/12/22 18:27:36, dcheng wrote:
> > Is this a temporary workaround? Or is this one of those 'view method needs
to
> > move to widget' things? Or some other category?
> 
> The whole zoom feature needs to be updated for out-of-process iframes, which
will move this around. I don't expect it to stay in RenderView and will move to
RenderFrame or possibly the equivalent of Page.
> 
> In the meantime, without out-of-process iframes, but with swapped out
disabled, we have a race where the zoom level IPC is sent from the browser right
after the swap out, which causes crashes.

Maybe add a TODO to that effect?

[nasko, 2015-12-22 19:32:02]

nasko@chromium.org changed reviewers:
+ nick@chromium.org

[nasko, 2015-12-22 19:32:02]

Hey Nick,
Can you review this CL for me?
Thanks!
Nasko

[dcheng, 2015-12-22 23:19:26]

lgtm

[Avi (use Gerrit), 2015-12-22 23:22:45]

avi@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2015-12-22 23:22:46]

lgtm

stampity stamp

[nasko, 2015-12-22 23:25:06]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2015-12-22 23:25:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1546603003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1546603003/40001

[commit-bot: I haz the power, 2015-12-23 00:16:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-23 00:17:39]

Description was changed from

==========
Ensure zoom level is not updated if main frame is WebRemoteFrame.

When swapped out RenderFrame is not used, the RenderView/WebView does not
have a main WebLocalFrame. This CL ensures the WebView code is not called
in such cases until it is updated to properly handle out-of-process iframes.

BUG=571603
==========

to

==========
Ensure zoom level is not updated if main frame is WebRemoteFrame.

When swapped out RenderFrame is not used, the RenderView/WebView does not
have a main WebLocalFrame. This CL ensures the WebView code is not called
in such cases until it is updated to properly handle out-of-process iframes.

BUG=571603

Committed: https://crrev.com/eaa6adc9f2b8463b7f5859e3b9faffecdd5225f1
Cr-Commit-Position: refs/heads/master@{#366698}
==========

[commit-bot: I haz the power, 2015-12-23 00:17:40]

Patchset 3 (id:??) landed as
https://crrev.com/eaa6adc9f2b8463b7f5859e3b9faffecdd5225f1
Cr-Commit-Position: refs/heads/master@{#366698}