Make image decoders faster by refactoring hot loops that fills the lines of ImageFrame.

Source/core/platform/image-decoders/jpeg/JPEGImageDecoder.cpp

 /*
  * Copyright (C) 2006 Apple Computer, Inc.
  *
  * Portions are Copyright (C) 2001-6 mozilla.org
  *
  * Other contributors:
  *   Stuart Parmenter <stuart@mozilla.com>
  *
  * Copyright (C) 2007-2009 Torch Mobile, Inc.
  *
@@ skipping 619 matching lines @@
     }
     return &frame;
 }
 
 bool JPEGImageDecoder::setFailed()
 {
     m_reader.clear();
     return ImageDecoder::setFailed();
 }
 
-template <J_COLOR_SPACE colorSpace> void setPixel(ImageFrame& buffer, ImageFrame::PixelData* pixel, JSAMPARRAY samples, int column)
-{
-    JSAMPLE* jsample = *samples + column * (colorSpace == JCS_RGB ? 3 : 4);
-
-    switch (colorSpace) {
-    case JCS_RGB:
-        buffer.setRGBA(pixel, jsample[0], jsample[1], jsample[2], 0xFF);
-        break;
-    case JCS_CMYK:
-        // Source is 'Inverted CMYK', output is RGB.
-        // See: http://www.easyrgb.com/math.php?MATH=M12#text12
-        // Or: http://www.ilkeratalay.com/colorspacesfaq.php#rgb
-        // From CMYK to CMY:
-        // X =   X    * (1 -   K   ) +   K  [for X = C, M, or Y]
-        // Thus, from Inverted CMYK to CMY is:
-        // X = (1-iX) * (1 - (1-iK)) + (1-iK) => 1 - iX*iK
-        // From CMY (0..1) to RGB (0..1):
-        // R = 1 - C => 1 - (1 - iC*iK) => iC*iK  [G and B similar]
-        unsigned k = jsample[3];
-        buffer.setRGBA(pixel, jsample[0] * k / 255, jsample[1] * k / 255, jsample[2] * k / 255, 0xFF);
-        break;
-    }
-}
-
-template <J_COLOR_SPACE colorSpace> bool outputRows(JPEGImageReader* reader, ImageFrame& buffer)
+static bool outputRows(JPEGImageReader* reader, ImageFrame& buffer, J_COLOR_SPACE colorSpace)
 {
     JSAMPARRAY samples = reader->samples();
     jpeg_decompress_struct* info = reader->info();
     int width = info->output_width;
 
     while (info->output_scanline < info->output_height) {
         // jpeg_read_scanlines will increase the scanline counter, so we
         // save the scanline before calling it.
         int y = info->output_scanline;
         // Request one scanline: returns 0 or 1 scanlines.
         if (jpeg_read_scanlines(info, samples, 1) != 1)
             return false;
 #if USE(QCMSLIB)
         if (reader->colorTransform() && colorSpace == JCS_RGB)
             qcms_transform_data(reader->colorTransform(), *samples, *samples, width);
 #endif
-        ImageFrame::PixelData* pixel = buffer.getAddr(0, y);
-        for (int x = 0; x < width; ++pixel, ++x)
-            setPixel<colorSpace>(buffer, pixel, samples, x);
+        unsigned const char* row = *samples;
+        if (colorSpace == JCS_RGB)
+            buffer.fillRowFromRGBSource(y, row);
+        else if (colorSpace == JCS_CMYK)
+            buffer.fillRowFromInvertedCMYK(y, row);
+        else
+            ASSERT_NOT_REACHED();
     }
 
     return true;
 }
 
 bool JPEGImageDecoder::outputScanlines()
 {
     if (m_frameBufferCache.isEmpty())
         return false;
 
@@ skipping 21 matching lines @@
                 return false;
 #if USE(QCMSLIB)
             if (qcms_transform* transform = m_reader->colorTransform())
                 qcms_transform_data_type(transform, row, row, info->output_width, rgbOutputColorSpace() == JCS_EXT_BGRA ? QCMS_OUTPUT_BGRX : QCMS_OUTPUT_RGBX);
 #endif
          }
          return true;
      }
 #endif
 
-    switch (info->out_color_space) {
-    case JCS_RGB:
-        return outputRows<JCS_RGB>(m_reader.get(), buffer);
-    case JCS_CMYK:
-        return outputRows<JCS_CMYK>(m_reader.get(), buffer);
-    default:
-        ASSERT_NOT_REACHED();
-    }
-
-    return setFailed();
+    return outputRows(m_reader.get(), buffer, info->out_color_space);
 }
 
 void JPEGImageDecoder::jpegComplete()
 {
     if (m_frameBufferCache.isEmpty())
         return;
 
     // Hand back an appropriately sized buffer, even if the image ended up being
     // empty.
     ImageFrame& buffer = m_frameBufferCache[0];
@@ skipping 13 matching lines @@
     // has failed.
     if (!m_reader->decode(*m_data, onlySize) && isAllDataReceived())
         setFailed();
     // If we're done decoding the image, we don't need the JPEGImageReader
     // anymore.  (If we failed, |m_reader| has already been cleared.)
     else if (!m_frameBufferCache.isEmpty() && (m_frameBufferCache[0].status() == ImageFrame::FrameComplete))
         m_reader.clear();
 }
 
 }