Issue 154653003: Count All Cards for Explanatory Link Support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 154653003: Count All Cards for Explanatory Link Support (Closed)

Created:
6 years, 10 months ago by robliao

Modified:
6 years, 10 months ago

Reviewers:
vadimt, rgustafson, skare_

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Count All Cards for Explanatory Link Support This change counts all cards indiscriminately for explanatory link purposes. Previously, we only counted location cards. BUG=340838 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250838

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -21 lines)			Patch
M	chrome/browser/resources/google_now/background.js	View	3 chunks	+10 lines, -12 lines	0 comments	Download
M	chrome/browser/resources/google_now/cards.js	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/google_now/cards_unittest.gtestjs	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/google_now/utility.js	View	1 chunk	+9 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

robliao

I'll hold off on committing this until the server is ready to accept this flag.

6 years, 10 months ago (2014-02-04 23:51:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/154653003/1

6 years, 10 months ago (2014-02-12 19:10:49 UTC) #5

Message was sent while issue was closed.

Change committed as 250838