Breakpad coverage for chrome_elf start up

chrome_elf/breakpad.h

Index: chrome_elf/breakpad.h
diff --git a/chrome_elf/breakpad.h b/chrome_elf/breakpad.h
new file mode 100644
index 0000000000000000000000000000000000000000..f76b67fc2d595176a231e86bfe64b5c4b8e6e4b0
--- /dev/null
+++ b/chrome_elf/breakpad.h
@@ -0,0 +1,34 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.

[grt (UTC plus 2), 2014/02/13 03:58:26]

no "(c)" in new copyright headers

[Cait (Slow), 2014/02/14 01:17:02]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_ELF_BREAKPAD_H_
+#define CHROME_ELF_BREAKPAD_H_
+
+#include <windows.h>
+
+namespace google_breakpad {
+  class ExceptionHandler;

[grt (UTC plus 2), 2014/02/13 03:58:26]

nit: don't indent here

[Cait (Slow), 2014/02/14 01:17:02]

Done.

+}
+
+// Initializes collection and upload of crash reports. The caller has to ensure

[grt (UTC plus 2), 2014/02/13 03:58:26]

it looks like the implementation checks for consent. please update comment.

[Cait (Slow), 2014/02/14 01:17:02]

Done.

+// that the user has agreed to crash dump reporting.
+//
+// Crash reporting has to be initialized as early as possible (e.g. the first

[grt (UTC plus 2), 2014/02/13 03:58:26]

nit: "e.g." -> "e.g.,"

[Cait (Slow), 2014/02/14 01:17:02]

Done.

+// thing in main()) to catch crashes occuring during process startup.
+// Crashes which occur during the global static construction phase will not
+// be caught and reported. This should not be a problem as static non-POD
+// objects are not allowed by the style guide and exceptions to this rule are
+// rare.
+void InitializeCrashReporting();
+
+// Generates a crashdump for the provided |exinfo|. This crashdump will be
+// either be saved locally, or uploaded, depending on how the ExceptionHandler
+// has been configured.
+int GenerateCrashDump(EXCEPTION_POINTERS* exinfo);
+
+// Global pointer to the ExceptionHandler. This is initialized by
+// InitializeCrashReporting() and used by GenerateCrashDump() to record dumps.
+extern google_breakpad::ExceptionHandler* g_elf_breakpad;
+
+#endif  // CHROME_ELF_BREAKPAD_H_