Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: chrome_elf/chrome_elf.gyp

Issue 154653002: Breakpad coverage for chrome_elf start up (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments and catch crashes in blacklist intercept code Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_elf/chrome_elf.gyp
diff --git a/chrome_elf/chrome_elf.gyp b/chrome_elf/chrome_elf.gyp
index 83514e73670541d8b6ddb75b63a8d780da09a97a..f25231a0c5b9e766f2c06508ee89ae2747240733 100644
--- a/chrome_elf/chrome_elf.gyp
+++ b/chrome_elf/chrome_elf.gyp
@@ -24,7 +24,10 @@
],
'dependencies': [
'blacklist',
+ 'chrome_elf_breakpad',
'chrome_elf_lib',
+ # TODO(caitkp): Why do we need this here?
+ '../breakpad/breakpad.gyp:breakpad_handler',
],
'msvs_settings': {
'VCLinkerTool': {
@@ -52,7 +55,6 @@
],
'include_dirs': [
'..',
- '<(SHARED_INTERMEDIATE_DIR)',
],
'dependencies': [
'chrome_elf_lib',
@@ -60,6 +62,7 @@
'../base/base.gyp:run_all_unittests',
'../base/base.gyp:test_support_base',
'../sandbox/sandbox.gyp:sandbox',
+ '../testing/gmock.gyp:gmock',
'../testing/gtest.gyp:gtest',
'blacklist',
'blacklist_test_dll_1',
@@ -96,6 +99,22 @@
'ntdll_cache.h',
],
},
+ {
+ 'target_name': 'chrome_elf_breakpad',
+ 'type': 'static_library',
+ 'include_dirs': [
+ '..',
+ '<(SHARED_INTERMEDIATE_DIR)',
+ ],
+ 'sources': [
+ 'breakpad.cc',
+ 'breakpad.h',
+ ],
+ 'dependencies': [
+ '../breakpad/breakpad.gyp:breakpad_handler',
+ '../chrome/chrome.gyp:chrome_version_header',
+ ],
+ },
], # targets
'conditions': [
['component=="shared_library"', {

Powered by Google App Engine
This is Rietveld 408576698