Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: chrome_elf/blacklist/blacklist.cc

Issue 154653002: Breakpad coverage for chrome_elf start up (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments and catch crashes in blacklist intercept code Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_elf/blacklist/blacklist.cc
diff --git a/chrome_elf/blacklist/blacklist.cc b/chrome_elf/blacklist/blacklist.cc
index bf48435e3e0475d1780df5226baa27297359e2bc..f82b6d3bb104f93d8f8f05bae684399df3ab256a 100644
--- a/chrome_elf/blacklist/blacklist.cc
+++ b/chrome_elf/blacklist/blacklist.cc
@@ -300,6 +300,7 @@ bool RemoveDllFromBlacklist(const wchar_t* dll_name) {
}
bool Initialize(bool force) {
+
robertshield 2014/02/10 18:43:14 nit: remove blank line
Cait (Slow) 2014/02/12 19:15:41 Done.
// Check to see that we found the functions we need in ntdll.
if (!InitializeInterceptImports())
return false;
@@ -424,7 +425,6 @@ bool Initialize(bool force) {
sizeof(g_thunk_storage),
PAGE_EXECUTE_READ,
&old_protect);
-
RecordSuccessfulThunkSetup(&key);
return NT_SUCCESS(ret) && page_executable;

Powered by Google App Engine
This is Rietveld 408576698