chrome_elf/blacklist.gypi - Issue 154653002: Breakpad coverage for chrome_elf start up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_elf/blacklist.gypi

Issue 154653002: Breakpad coverage for chrome_elf start up (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments and catch crashes in blacklist intercept code Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome_elf/blacklist.gypi

diff --git a/chrome_elf/blacklist.gypi b/chrome_elf/blacklist.gypi

index 2db49417b9e0b1d04af46ed9d3eb71121b50166c..ecd745afc9200eebafbf90cc27cd6687d646004c 100644

--- a/chrome_elf/blacklist.gypi

+++ b/chrome_elf/blacklist.gypi

@@ -7,6 +7,7 @@

'target_name': 'blacklist',

'type': 'static_library',

'include_dirs': [

+ '..',

'<(SHARED_INTERMEDIATE_DIR)',

'sources': [

@@ -21,7 +22,10 @@

# chrome_elf cannot do.

'../base/base.gyp:base_static',

'../chrome/chrome.gyp:chrome_version_header',

- '../sandbox/sandbox.gyp:sandbox',

+ '../chrome_elf/chrome_elf.gyp:chrome_elf_breakpad',

+ # TODO(caitkp): Why do we need this here?

robertshield 2014/02/10 18:43:14 possibly for the test target (blacklist_test_main_

Cait (Slow) 2014/02/12 19:15:41 Fixed by fwd declaring the ExceptionHandler.

+ '../breakpad/breakpad.gyp:breakpad_handler',

+ '../sandbox/sandbox.gyp:sandbox',

{