Issue 15465005: Reland path bounds change with correct bounds for convex and hairline path renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15465005: Reland path bounds change with correct bounds for convex and hairline path renderers. (Closed)

Created:
7 years, 7 months ago by bsalomon

Modified:
7 years, 7 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Reland path bounds change with correct bounds for convex and hairline path renderers. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=9194

Patch Set 2 : tighter tolerances #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -22 lines)			Patch
M	src/gpu/GrAAConvexPathRenderer.cpp	View	1	2 chunks	+20 lines, -1 line	0 comments	Download
M	src/gpu/GrAAHairLinePathRenderer.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrAAHairLinePathRenderer.cpp	View	1	10 chunks	+55 lines, -10 lines	1 comment	Download
M	src/gpu/GrDefaultPathRenderer.cpp	View		3 chunks	+7 lines, -8 lines	0 comments	Download
M	src/gpu/GrPathRenderer.h	View		2 chunks	+17 lines, -1 line	0 comments	Download
M	src/gpu/GrPathRenderer.cpp	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + 1 future possibility https://codereview.chromium.org/15465005/diff/8/src/gpu/GrAAHairLinePathRenderer.cpp File src/gpu/GrAAHairLinePathRenderer.cpp (right): https://codereview.chromium.org/15465005/diff/8/src/gpu/GrAAHairLinePathRenderer.cpp#newcode836 src/gpu/GrAAHairLinePathRenderer.cpp:836: #if GR_DEBUG I have ...

7 years, 7 months ago (2013-05-20 13:50:42 UTC) #2

bsalomon

7 years, 7 months ago (2013-05-20 16:49:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r9194 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15465005: Reland path bounds change with correct bounds for convex and hairline path renderers. (Closed)

Description

Patch Set 1 #

Patch Set 2 : tighter tolerances #

Messages