Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1546493003: Revert of Add web compat workarounds for ES2015 RegExp semantics (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
yangguo, Dan Ehrenberg, Yang
CC:
caitp (gmail), Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add web compat workarounds for ES2015 RegExp semantics (patchset #3 id:40001 of https://codereview.chromium.org/1543723002/ ) Reason for revert: Breaks nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/5883 Original issue's description: > Add web compat workarounds for ES2015 RegExp semantics > > Unexpectedly, websites depend on doing feature testing with > RegExp.prototype.sticky and browser testing with RegExp.prototype.toString(). > ES2015 newly throws exceptions for both of these. In order to enable shipping > new ES2015 semantics, this patch puts in narrow workarounds for those two > cases, keeping their old behavior. UseCounters are added for how often > those particular cases come up, so we can see if it can be deprecated. > > R=yangguo > BUG=v8:4637, v8:4617 > LOG=Y > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/98f819c3e0c92d54a306cdacadda73cf96d21b52 > Cr-Commit-Position: refs/heads/master@{#32997} TBR=yangguo@google.com,yangguo@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4637, v8:4617 Committed: https://crrev.com/08a1d1a28847caf62a996d93f11da982d2649061 Cr-Commit-Position: refs/heads/master@{#32999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -119 lines) Patch
M include/v8.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/js/harmony-regexp.js View 2 chunks +0 lines, -8 lines 0 comments Download
M src/js/regexp.js View 2 chunks +1 line, -11 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M test/cctest/test-regexp.cc View 2 chunks +0 lines, -80 lines 0 comments Download
M test/mjsunit/es6/regexp-flags.js View 1 chunk +1 line, -5 lines 0 comments Download
M test/webkit/fast/js/kde/RegExp-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/regex/toString-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
Created Revert of Add web compat workarounds for ES2015 RegExp semantics
5 years ago (2015-12-22 07:36:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546493003/1
5 years ago (2015-12-22 07:37:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-22 07:37:13 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-22 07:38:04 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08a1d1a28847caf62a996d93f11da982d2649061
Cr-Commit-Position: refs/heads/master@{#32999}

Powered by Google App Engine
This is Rietveld 408576698