Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: net/http/http_server_properties_manager.h

Issue 1546493002: HttpServerProperties - Minor reorganization of code in preperation of (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use ServerList - fix comments for PatchSet 1 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_server_properties_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_server_properties_manager.h
diff --git a/net/http/http_server_properties_manager.h b/net/http/http_server_properties_manager.h
index ef881572c5a450828da79c7a82f1a2682415168f..6779a2147672da241c719bb2a99460a549bc789d 100644
--- a/net/http/http_server_properties_manager.h
+++ b/net/http/http_server_properties_manager.h
@@ -216,14 +216,19 @@ class NET_EXPORT HttpServerPropertiesManager : public HttpServerProperties {
const base::Closure& completion);
private:
+ typedef std::vector<std::string> ServerList;
+
FRIEND_TEST_ALL_PREFIXES(HttpServerPropertiesManagerTest,
AddToAlternativeServiceMap);
FRIEND_TEST_ALL_PREFIXES(HttpServerPropertiesManagerTest,
DoNotLoadExpiredAlternativeService);
void OnHttpServerPropertiesChanged();
- bool ReadSupportsQuic(const base::DictionaryValue& server_dict,
- IPAddressNumber* last_quic_address);
+ bool AddServersData(const base::DictionaryValue& server_dict,
+ ServerList* spdy_servers,
+ SpdySettingsMap* spdy_settings_map,
+ AlternativeServiceMap* alternative_service_map,
+ ServerNetworkStatsMap* network_stats_map);
void AddToSpdySettingsMap(const HostPortPair& server,
const base::DictionaryValue& server_dict,
SpdySettingsMap* spdy_settings_map);
@@ -235,6 +240,8 @@ class NET_EXPORT HttpServerPropertiesManager : public HttpServerProperties {
const HostPortPair& server,
const base::DictionaryValue& server_dict,
AlternativeServiceMap* alternative_service_map);
+ bool ReadSupportsQuic(const base::DictionaryValue& server_dict,
+ IPAddressNumber* last_quic_address);
bool AddToNetworkStatsMap(const HostPortPair& server,
const base::DictionaryValue& server_dict,
ServerNetworkStatsMap* network_stats_map);
@@ -246,15 +253,15 @@ class NET_EXPORT HttpServerPropertiesManager : public HttpServerProperties {
void SaveAlternativeServiceToServerPrefs(
const AlternativeServiceInfoVector* alternative_service_info_vector,
base::DictionaryValue* server_pref_dict);
+ void SaveSupportsQuicToPrefs(
+ const IPAddressNumber* last_quic_address,
+ base::DictionaryValue* http_server_properties_dict);
void SaveNetworkStatsToServerPrefs(
const ServerNetworkStats* server_network_stats,
base::DictionaryValue* server_pref_dict);
void SaveQuicServerInfoMapToServerPrefs(
QuicServerInfoMap* quic_server_info_map,
base::DictionaryValue* http_server_properties_dict);
- void SaveSupportsQuicToPrefs(
- const IPAddressNumber* last_quic_address,
- base::DictionaryValue* http_server_properties_dict);
// -----------
// Pref thread
« no previous file with comments | « no previous file | net/http/http_server_properties_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698