Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1546443002: Merge to XFA: Fix JS seconds since epoch to date conversions. (Closed)

Created:
5 years ago by Lei Zhang
Modified:
5 years ago
Reviewers:
Tom Sepez, Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix JS seconds since epoch to date conversions. BUG=515137, 564736 TBR=ochang@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1533233002 . Review URL: https://codereview.chromium.org/1544493003 . (cherry picked from commit b426e3edde040089b70d1a223c83b90957aa571d) (cherry picked from commit bd35d484a4027775f19ff93e9143e0b270133d42) Committed: https://pdfium.googlesource.com/pdfium/+/1ac47ebfc2d106e25c3e13062cae2132daa49348

Patch Set 1 #

Patch Set 2 : XFA changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -54 lines) Patch
M BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Value.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
A fpdfsdk/src/javascript/public_methods_embeddertest.cpp View 1 1 chunk +165 lines, -0 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp View 2 chunks +3 lines, -48 lines 0 comments Download
M pdfium.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M testing/embedder_test.h View 1 chunk +1 line, -1 line 0 comments Download
M testing/embedder_test.cpp View 1 chunk +1 line, -1 line 0 comments Download
A testing/js_embedder_test.h View 1 chunk +32 lines, -0 lines 0 comments Download
A testing/js_embedder_test.cpp View 1 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Lei Zhang
TBR, there's some trivial XFA-only changes in patch set 2.
5 years ago (2015-12-21 19:04:36 UTC) #1
Lei Zhang
5 years ago (2015-12-21 19:04:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1ac47ebfc2d106e25c3e13062cae2132daa49348 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698