Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 154643005: Remove references to non-Aura Win WebThemeEngine implementation. (Closed)

Created:
6 years, 10 months ago by Dirk Pranke
Modified:
6 years, 10 months ago
Reviewers:
jamesr, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Remove references to non-Aura Win WebThemeEngine implementation. R=jamesr@chromium.org, piman@chromium.org BUG=327471, 330735 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250510

Patch Set 1 #

Patch Set 2 : remove files from the gypi also #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1068 lines) Patch
D content/child/webthemeengine_impl_win.h View 1 chunk +0 lines, -49 lines 0 comments Download
D content/child/webthemeengine_impl_win.cc View 1 chunk +0 lines, -1014 lines 0 comments Download
M content/content_child.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/test_webkit_platform_support.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Dirk Pranke
6 years, 10 months ago (2014-02-05 01:16:43 UTC) #1
jamesr
lgtm
6 years, 10 months ago (2014-02-05 01:19:14 UTC) #2
Dirk Pranke
John, can I get an OWNERS approval?
6 years, 10 months ago (2014-02-05 19:42:18 UTC) #3
Dirk Pranke
Looks like jam@ is out, piman@, can you give an OWNERS approval for this?
6 years, 10 months ago (2014-02-06 00:32:29 UTC) #4
piman
lgtm
6 years, 10 months ago (2014-02-06 00:43:28 UTC) #5
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 10 months ago (2014-02-06 00:43:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/154643005/1
6 years, 10 months ago (2014-02-06 00:48:44 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 01:16:53 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=258290
6 years, 10 months ago (2014-02-06 01:16:54 UTC) #9
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 10 months ago (2014-02-06 19:01:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/154643005/370001
6 years, 10 months ago (2014-02-06 19:07:07 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 19:39:41 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=225562
6 years, 10 months ago (2014-02-06 19:39:41 UTC) #13
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 10 months ago (2014-02-11 18:09:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/154643005/370001
6 years, 10 months ago (2014-02-11 18:09:30 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 21:21:19 UTC) #16
Message was sent while issue was closed. 
Change committed as 250510

Powered by Google App Engine
This is Rietveld 408576698