Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 15464016: Revert 201204 "add more string -> unsigned number conversion uni..." (Closed)

Created:
7 years, 7 months ago by hashimoto
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 201204 "add more string -> unsigned number conversion uni..." This change generates "integer constant is too large for 'unsigned long' type" compile error on "Google Chrome Linux" buildbot > add more string -> unsigned number conversion unit tests > > Add unit tests for the following functions in base: > StringToUint > StringToUint64 > StringToSizeT > > Review URL: https://chromiumcodereview.appspot.com/14794002 TBR=mostynb@opera.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -197 lines) Patch
M trunk/src/base/strings/string_number_conversions_unittest.cc View 3 chunks +0 lines, -197 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
7 years, 7 months ago (2013-05-21 05:34:51 UTC) #1
hashimoto
Committed patchset #1 manually as r201237.
7 years, 7 months ago (2013-05-21 05:35:40 UTC) #2
hashimoto
On 2013/05/21 05:35:40, hashimoto wrote: > Committed patchset #1 manually as r201237. Please see http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/30177 ...
7 years, 7 months ago (2013-05-21 05:36:55 UTC) #3
hashimoto
On 2013/05/21 05:36:55, hashimoto wrote: > On 2013/05/21 05:35:40, hashimoto wrote: > > Committed patchset ...
7 years, 7 months ago (2013-05-21 05:37:45 UTC) #4
Mostyn Bramley-Moore
7 years, 7 months ago (2013-05-21 06:02:14 UTC) #5
Message was sent while issue was closed.
Resubmitted with proposed fix here:
https://codereview.chromium.org/15521004/

Powered by Google App Engine
This is Rietveld 408576698