Allow \n in GN string literals

GN: Allow escape codes to be embedded in strings via $0xFF

I've wanted to use them when writing assert messages. Might also be
useful in write_file().

BUG=

Committed: https://crrev.com/f59e82f6169caace177e452c06377b3d611ed978
Cr-Commit-Position: refs/heads/master@{#367622}

[agrieve, 2015-12-28 20:39:27]

ↂ

[agrieve, 2015-12-28 20:40:00]

agrieve@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2015-12-29 04:11:20]

The current escaping is designed to allow most Windows paths (using backslashes)
to be expressed with no extra escaping. We can consider the pros and cons of
moving away from that, but then we should make \ followed by a random letter an
error which will break some build scripts.

[agrieve, 2016-01-04 16:28:51]

On 2015/12/29 04:11:20, brettw wrote:
> The current escaping is designed to allow most Windows paths (using
backslashes)
> to be expressed with no extra escaping. We can consider the pros and cons of
> moving away from that, but then we should make \ followed by a random letter
an
> error which will break some build scripts.

Hmm, certainly don't care enough about this to put a lot of time into it.
Perhaps add a magic  global called $newline, or allow unicode via $0xFF?

[brettw, 2016-01-04 18:31:23]

On 2016/01/04 16:28:51, agrieve wrote:
> On 2015/12/29 04:11:20, brettw wrote:
> > The current escaping is designed to allow most Windows paths (using
> backslashes)
> > to be expressed with no extra escaping. We can consider the pros and cons of
> > moving away from that, but then we should make \ followed by a random letter
> an
> > error which will break some build scripts.
> 
> Hmm, certainly don't care enough about this to put a lot of time into it.
> Perhaps add a magic  global called $newline, or allow unicode via $0xFF?

$0xFF is a good syntax since it uses the existing $ thing and 0 isn't a valid
variable name beginning char so it won't clash with anything else.

[agrieve, 2016-01-05 15:12:00]

Description was changed from

==========
Allow \n in GN string literals

I've wanted to use them when writing assert messages. Might also be
useful in write_file().

BUG=
==========

to

==========
GN: Allow escape codes to be embedded in strings via $0xFF

I've wanted to use them when writing assert messages. Might also be
useful in write_file().

BUG=
==========

[brettw, 2016-01-05 18:11:04]

lgtm

https://codereview.chromium.org/1546393002/diff/40001/tools/gn/string_utils.cc
File tools/gn/string_utils.cc (right):

https://codereview.chromium.org/1546393002/diff/40001/tools/gn/string_utils.c...
tools/gn/string_utils.cc:232: output->push_back(value);
I'm surprised you can push_back an into on a string without a warning on any
platform.

[agrieve, 2016-01-05 19:43:19]

https://codereview.chromium.org/1546393002/diff/40001/tools/gn/string_utils.cc
File tools/gn/string_utils.cc (right):

https://codereview.chromium.org/1546393002/diff/40001/tools/gn/string_utils.c...
tools/gn/string_utils.cc:232: output->push_back(value);
On 2016/01/05 18:11:04, brettw wrote:
> I'm surprised you can push_back an into on a string without a warning on any
> platform.

Yeah, just tried both GCC and clang again but no warnings (confirmed -Wall and
-Wextra exist). Will let the presubmit check msvc

[agrieve, 2016-01-05 19:43:25]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-01-05 19:45:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1546393002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1546393002/40001

[commit-bot: I haz the power, 2016-01-05 20:09:11]

Description was changed from

==========
GN: Allow escape codes to be embedded in strings via $0xFF

I've wanted to use them when writing assert messages. Might also be
useful in write_file().

BUG=
==========

to

==========
GN: Allow escape codes to be embedded in strings via $0xFF

I've wanted to use them when writing assert messages. Might also be
useful in write_file().

BUG=
==========

[commit-bot: I haz the power, 2016-01-05 20:09:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-05 20:11:04]

Description was changed from

==========
GN: Allow escape codes to be embedded in strings via $0xFF

I've wanted to use them when writing assert messages. Might also be
useful in write_file().

BUG=
==========

to

==========
GN: Allow escape codes to be embedded in strings via $0xFF

I've wanted to use them when writing assert messages. Might also be
useful in write_file().

BUG=

Committed: https://crrev.com/f59e82f6169caace177e452c06377b3d611ed978
Cr-Commit-Position: refs/heads/master@{#367622}
==========

[commit-bot: I haz the power, 2016-01-05 20:11:05]

Patchset 3 (id:??) landed as
https://crrev.com/f59e82f6169caace177e452c06377b3d611ed978
Cr-Commit-Position: refs/heads/master@{#367622}